-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Certora] Dispatch tokens and verify safe transfer lib #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoenicke
suggested changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also wonder if we want some small unit tests, like:
- safeTransfer and safeTransferFrom revert if balance not enough.
- safeTransferFrom reverts if not authorized.
- safeTransfer does not revert if balance is enough.
Co-authored-by: Jochen Hoenicke <hoenicke@gmail.com> Signed-off-by: Quentin Garchery <QGarchery@users.noreply.github.com>
QGarchery
force-pushed
the
certora/dispatch-tokens
branch
from
August 17, 2023 07:59
c2f30b0
to
7125c7d
Compare
jhoenicke
approved these changes
Aug 17, 2023
Merging this and adding your suggestions as a new issue #342 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines the tokens
ERC20Good
andERC20USDT
that should behave correctly when setting up a new market, and defines a buggy tokenERC20Bad
. It also uses those to verify that the summary of the transfer is valid for the tokens that behave correctly.