Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify transfer lib more thoroughly #342

Closed
QGarchery opened this issue Aug 17, 2023 · 1 comment
Closed

Verify transfer lib more thoroughly #342

QGarchery opened this issue Aug 17, 2023 · 1 comment
Assignees
Labels
verif Modifies the formal verification

Comments

@QGarchery
Copy link
Contributor

I also wonder if we want some small unit tests, like:

  • safeTransfer and safeTransferFrom revert if balance not enough.
  • safeTransferFrom reverts if not authorized.
  • safeTransfer does not revert if balance is enough.

Originally posted by @jhoenicke in #321 (review)

@QGarchery QGarchery self-assigned this Aug 17, 2023
@QGarchery QGarchery added the verif Modifies the formal verification label Aug 17, 2023
@QGarchery QGarchery changed the title Verify transfer lib more thouroughly Verify transfer lib more thoroughly Aug 17, 2023
@QGarchery
Copy link
Contributor Author

Done in #346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verif Modifies the formal verification
Projects
None yet
Development

No branches or pull requests

1 participant