Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#246] Add is_standaard_adres for DigitaalAdres #269

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stevenbal
Copy link
Collaborator

Fixes #246

Changes

  • Add is_standaard_adres for DigitaalAdres

@stevenbal stevenbal marked this pull request as draft October 17, 2024 15:04
@stevenbal stevenbal marked this pull request as ready for review October 18, 2024 08:11
is_standaard_adres=True is unique per soort_digitaal_adres and setting a new default, revokes the other default
Copy link
Contributor

@bart-maykin bart-maykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also change the validation for the voorkeur digitaal adress to only allow these default addresses. Because I don't see a scenario where this would be wanted behavior.

@stevenbal
Copy link
Collaborator Author

@bart-maykin @joeribekker hmm you're right, though upon looking at this again, I don't know if what I implemented here makes sense to begin with actually, because with the current logic there can only be three default addresses in total (one for each type). Should I add the betrokkene and partij to the condition in the unique constraint as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store default address per 'soort digitaal adres'
2 participants