Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store default address per 'soort digitaal adres' #246

Open
mariusvandam opened this issue Sep 12, 2024 · 1 comment · May be fixed by #269
Open

Store default address per 'soort digitaal adres' #246

mariusvandam opened this issue Sep 12, 2024 · 1 comment · May be fixed by #269
Assignees
@stevenbal
Labels
approved discuss enhancement New feature or request owner: dimpact

Comments

@mariusvandam
Copy link

Thema / Theme

Klantinteracties API

Omschrijving / Description

Acceptance criteria

  • At any time only a single digital address can be default per 'soort digitaal adress'
  • It is possible to set the default
  • It is possible to change the default

Toegevoegde waarde / Added value

In case there are multiple digital addresses of a certain type, it is needed to know which one to use for a certain communication. The existing 'voorkeur digitaal adress' is not enough as that may be an address which cannot be used for a certain communication

Aanvullende opmerkingen / Additional context

No response
@mariusvandam mariusvandam added enhancement New feature or request triage labels Sep 12, 2024
stevenbal added a commit that referenced this issue Oct 17, 2024
@stevenbal
✨ [#246] Add is_standaard_adres for DigitaalAdres
51d4e12
stevenbal added a commit that referenced this issue Oct 17, 2024
@stevenbal
✅ [#246] Add tests for DigitaalAdres.is_standaard_adres
e9eabe8
@stevenbal stevenbal linked a pull request Oct 17, 2024 that will close this issue
Draft
stevenbal added a commit that referenced this issue Oct 18, 2024
@stevenbal
✨ [#246] Add is_standaard_adres for DigitaalAdres
4c9e506 
is_standaard_adres=True is unique per soort_digitaal_adres and setting a new default, revokes the other default
stevenbal added a commit that referenced this issue Oct 18, 2024
@stevenbal
✅ [#246] Add tests for DigitaalAdres.is_standaard_adres
b139ff3
stevenbal added a commit that referenced this issue Oct 24, 2024
@stevenbal
✨ [#246] Add is_standaard_adres for DigitaalAdres
da126a7 
is_standaard_adres=True is unique per soort_digitaal_adres and setting a new default, revokes the other default
stevenbal added a commit that referenced this issue Oct 24, 2024
@stevenbal
✅ [#246] Add tests for DigitaalAdres.is_standaard_adres
c93f378
@stevenbal
Copy link
Collaborator

stevenbal commented Oct 25, 2024 •
edited
Loading

@joeribekker I made the PR draft, because I'm not sure if my implementation is correct, it might be good to discuss this next week: #269 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenbal stevenbal

Labels
approved discuss enhancement New feature or request owner: dimpact
Projects
Data en API fundament
Status: Implemented
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ [#246] Add is_standaard_adres for DigitaalAdres maykinmedia/open-klant
3 participants
@joeribekker @mariusvandam @stevenbal