Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested solution to 'yielder' problem in resources.py #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Suggested solution to 'yielder' problem in resources.py #7

wants to merge 2 commits into from

Commits on Aug 17, 2021

  1. Suggested solution to 'yielder' problem in resources.py 

    The yielder() took away the advantages of a generator: generate the data in place. By the yielder, the program had to go through the whole generator function before knowing the pagination. This became problematic for huge data sets (i.e. >15000). With the proposed design, the actual query is delivered alongside with the store to the generator function and the generator is fed with the restriction. The restriction is necessary, as only folder.items has a query parameter, whereas folder.folders and folder.items both have a restriction parameter.
    @marlemion
    marlemion authored Aug 17, 2021
    Configuration menu
    Copy the full SHA
    e0ea23a View commit details
    Browse the repository at this point in the history

  2. Update resource.py 

    Forgot the most important part
    @marlemion
    marlemion authored Aug 17, 2021
    Configuration menu
    Copy the full SHA
    b6dc98f View commit details
    Browse the repository at this point in the history