Suggested solution to 'yielder' problem in resources.py #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The yielder() took away the advantages of a generator: generate the data in place. By the yielder, the program had to go through the whole generator function before knowing the pagination. This became problematic for huge data sets (i.e. >15000). With the proposed design, the actual query is delivered alongside with the store to the generator function and the generator is fed with the restriction. The restriction is necessary, as only folder.items has a query parameter, whereas folder.folders and folder.items both have a restriction parameter.
Forgot the most important part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The yielder() took away the advantages of a generator: generate the data in place. By the yielder, the program had to go through the whole generator function before knowing the pagination. This became problematic for huge data sets (i.e. >15000). With the proposed design, the actual query is delivered alongside with the store to the generator function and the generator is fed with the restriction. The restriction is necessary, as only folder.items has a query parameter, whereas folder.folders and folder.items both have a restriction parameter.