-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DataStax Astra DB vector store driver #1022
Add DataStax Astra DB vector store driver #1022
Conversation
Thanks for the PR @hemidactylus! Will review this in detail next week. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Thank you so much, @collindutter ! Meanwhile I should have addressed the test coverage issues reported above. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you for putting the time into creating consistent documentation and passing tests -- it is greatly appreciated :)
tests/integration/drivers/vector/test_astra_db_vector_store_driver.py
Outdated
Show resolved
Hide resolved
tests/integration/drivers/vector/test_astra_db_vector_store_driver.py
Outdated
Show resolved
Hide resolved
tests/integration/drivers/vector/test_astra_db_vector_store_driver.py
Outdated
Show resolved
Hide resolved
tests/integration/drivers/vector/test_astra_db_vector_store_driver.py
Outdated
Show resolved
Hide resolved
- simplify the 'query webpage Astra' markdown page - add env.vars to the CI action yaml - remove Griptape version detection - remove mistakenly-added logging level setting - moved the "indexing" value to a class attribute - reinstated `dimensions` as a required parameter - removed kwargs warnings from methods (and implications thereof) - replaced implicit-bool checks with "is None" checks in a few places - (testing) move sample docs and Entries to being pytest fixtures - (testing) move utility function `_descore_entry` into a class method
…iver to supply required functionality.
(replying about the renaming of the Sounds good to me -- renamed. Only, I had to take out the
(alternatively, I guess |
tests/integration/drivers/vector/test_astra_db_vector_store_driver.py
Outdated
Show resolved
Hide resolved
Great work again @hemidactylus! And thanks for working with me through the requested changes. Just need to do some testing on a live AstraDb instance and then we'll be good to merge 🥳 |
That's great news @collindutter ! Do you want me to assist you with the (actually very simple) setup for integration testing? Please do let me know! |
I appreciate the offer! I should be good, but will reach out if I have any questions. |
@hemidactylus I tested it out, everything worked great! I'm recreating the PR in our repo so that integration tests can run with our secrets, but all the commits from your fork are still present. Thanks again for the excellent integration. |
Describe your changes
Adds an
AstraDBVectorStoreDriver
class, plus:Notes
I can run the integration testing on my machine (all green). Depending on Griptape's policy on integration testing, I can share secrets to a dedicated CI database or similar, just let me know if that is a valid option.
Also, I noticed that the number of returned vectors in the
query
method is generally calledcount
(as I did and as other drivers do); but at least one example in the docs seems to refer to it astop_n
. Is it preferred that the method accepts both parameter names, perhaps?Issue ticket number and link
Closes #1021
📚 Documentation preview 📚: https://griptape--1022.org.readthedocs.build//1022/