Add DataStax Astra DB vector store driver #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- simplify the 'query webpage Astra' markdown page - add env.vars to the CI action yaml - remove Griptape version detection - remove mistakenly-added logging level setting - moved the "indexing" value to a class attribute - reinstated `dimensions` as a required parameter - removed kwargs warnings from methods (and implications thereof) - replaced implicit-bool checks with "is None" checks in a few places - (testing) move sample docs and Entries to being pytest fixtures - (testing) move utility function `_descore_entry` into a class method
…iver to supply required functionality.
vachillo
previously approved these changes
Jul 31, 2024
collindutter
force-pushed
the
SL-astra-db-vector-store
branch
from
bc00e1c
to
208fb2e
Compare
vachillo
previously approved these changes
Jul 31, 2024
collindutter
force-pushed
the
SL-astra-db-vector-store
branch
from
208fb2e
to
bdef2ae
Compare
vachillo
approved these changes
Jul 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
Thank you @collindutter and @vachillo for the extremely fast and helpful review process! |
|
Hello, @collindutter - a thought occurred to me that if you set up Astra DB CI/CD with a free-tier Astra account, the database will go into hibernation after one (perhaps two?) days of inactivity, and the integration tests would fail. |
|
Thanks for the offer @hemidactylus -- what's the best way to get in touch? Are you in our discord? |
collindutter
added a commit
that referenced
this pull request
Aug 2, 2024
Co-authored-by: Stefano Lottini <stefano.lottini@datastax.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Recreating the PR in our repo so that integration tests can run
Issue ticket number and link
Closes #1021
Closes #1022
📚 Documentation preview 📚: https://griptape--1034.org.readthedocs.build//1034/