Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/9281 Refactor Audience Segmentation Setup Success Notification #9434

Merged
merged 18 commits into from
Oct 13, 2024
Merged

Enhancement/9281 Refactor Audience Segmentation Setup Success Notification #9434

merged 18 commits into from
Oct 13, 2024
+91 −123

Commits on Sep 23, 2024

  1. Register the Audiences Setup Success Banner Notification.

    @jimmymadon
    jimmymadon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    96eae24 View commit details
    Browse the repository at this point in the history

  2. Initialize all analytics specific registered notifications.

    @jimmymadon
    jimmymadon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d56f1d0 View commit details
    Browse the repository at this point in the history

  3. Add requirements checks for Audiences Setup Success notification.

    @jimmymadon
    jimmymadon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c39fb4d View commit details
    Browse the repository at this point in the history

  4. Remove all redundant logic from Audiences Setup Success Subtle Notifi… 

    …cation.
    @jimmymadon
    jimmymadon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0a1fb30 View commit details
    Browse the repository at this point in the history

  5. Refactor the audiences setup success notification to use the new noti… 

    …fications infrastructure components.
    @jimmymadon
    jimmymadon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    adb29ff View commit details
    Browse the repository at this point in the history

  6. Use a constant for the audiences setup success notification ID.

    @jimmymadon
    jimmymadon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e545757 View commit details
    Browse the repository at this point in the history

  7. Fix format of audiences setup success notification ID.

    @jimmymadon
    jimmymadon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    02e07f7 View commit details
    Browse the repository at this point in the history

  8. Use the Notifications datastore to dismiss the audiences notification… 

    … instead of using Dismissed Items directly.
    @jimmymadon
    jimmymadon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    95b8d7d View commit details
    Browse the repository at this point in the history

  9. Update notification ID for dismissed items reset check.

    @jimmymadon
    jimmymadon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ca3e0e5 View commit details
    Browse the repository at this point in the history

  10. Remove direct call to the Audience Segmentation setup success notific… 

    …ation.
    @jimmymadon
    jimmymadon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    58040a2 View commit details
    Browse the repository at this point in the history

  11. Remove deprecated passing of viewContext.

    @jimmymadon
    jimmymadon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0278e52 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Fix Audiences Setup Success notification story.

    @jimmymadon
    jimmymadon committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    eb603e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Re-evaluate notification queue when audiences are configured.

    @jimmymadon
    jimmymadon committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    734bfb0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into enhancement/9281-refactor-audience-segeme… 

    …ntation-setup-success-notification.
    @jimmymadon
    jimmymadon committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    e6b6ef3 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge branch 'develop' into enhancement/9281-refactor-audience-segeme… 

    …ntation-setup-success-notification.
    @jimmymadon
    jimmymadon committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b79c884 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge remote-tracking branch 'origin/develop' into enhancement/9281-r… 

    …efactor-audience-segementation-setup-success-notification.
    @benbowler
    benbowler committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    53aa127 View commit details
    Browse the repository at this point in the history

  2. Wrap audience segmentation notification registration with feature flag.

    @jimmymadon
    jimmymadon committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7fecdc9 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Merge branch 'develop' into enhancement/9281-refactor-audience-segeme… 

    …ntation-setup-success-notification.
    @jimmymadon
    jimmymadon committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3fac4fa View commit details
    Browse the repository at this point in the history