Enhancement/9281 Refactor Audience Segmentation Setup Success Notification #9434
+91
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fications infrastructure components.
… instead of using Dismissed Items directly.
…ntation-setup-success-notification.
|
Build files for 3fac4fa have been deleted. |
…ntation-setup-success-notification.
|
Size Change: -2.79 kB (-0.15%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
…efactor-audience-segementation-setup-success-notification.
benbowler
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Hey @jimmymadon, the implementation looks good and tests well.
Looking at the failing checks it appears there are E2E tests and perhaps JS test failures which are directly related to these changes. Can you check those?
|
@benbowler Thanks - I think the E2E test failures are now just related to the cron issue. Adding the feature flag helped everything else. |
benbowler
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Thanks @jimmymadon, good update to wrap the notification in the feature flag. I've looked through the changes and re-tested and moving to MR.
…ntation-setup-success-notification.
jimmymadon
changed the title
eugene-manuilov
approved these changes
Oct 13, 2024
eugene-manuilov
deleted the
enhancement/9281-refactor-audience-segementation-setup-success-notification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
@techanvil and I discussed the possibility of creating an "On demand" notification instead of simply reevaluating the queue using "invalidateResolution". However, on my recent one to one with @aaemnnosttv, we think this can be thought through more in a separate issue where we refactor this particular notification to create a more robust "on demand" notification. So I've created a new issue for this: #9453
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist