Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: host takes ownership of memory blocks it gets as arguments #90

Merged
merged 8 commits into from
Sep 23, 2024
Merged

cleanup: host takes ownership of memory blocks it gets as arguments #90

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9e1a43e
cleanup: add calls to free
zshipko Sep 18, 2024
56cdb73
cleanup: host takes ownership of memory handles passed to config/var/…
zshipko Sep 19, 2024
ee78607
fix: free isn't a method
zshipko Sep 19, 2024
4a565c3
fix: addrs should be number not bigint
zshipko Sep 19, 2024
cc12813
fix: Number not number
zshipko Sep 19, 2024
fe558a2
fix: don't free valueaddr in var_set
zshipko Sep 19, 2024
5e1d1f3
fix: preserve key in var_set
zshipko Sep 19, 2024
97f5853
fix: use bigint for values passed to free
zshipko Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/call-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export class CallContext {
return this.alloc(n);
},

free: (addr: number): void => {
free: (addr: number | bigint): void => {
this.#blocks[Block.addressToIndex(addr)] = null;
},

Expand Down Expand Up @@ -296,6 +296,8 @@ export class CallContext {

const key = item.string();

this[ENV].free(addr);

if (key in this.#config) {
return this.store(this.#config[key]);
}
Expand All @@ -311,6 +313,8 @@ export class CallContext {
}

const key = item.string();
this[ENV].free(addr);

const result = this.getVariable(key);
const stored = result ? this[STORE](result.bytes()) || 0 : 0;
return Block.indexToAddress(stored)
Expand Down Expand Up @@ -380,6 +384,7 @@ export class CallContext {
}
const text = this.#decoder.decode(block.buffer);
this.#logger.warn(text);
this[ENV].free(addr);
},

log_info: (addr: bigint) => {
Expand All @@ -393,6 +398,7 @@ export class CallContext {
}
const text = this.#decoder.decode(block.buffer);
this.#logger.info(text);
this[ENV].free(addr);
},

log_debug: (addr: bigint) => {
Expand All @@ -406,6 +412,7 @@ export class CallContext {
}
const text = this.#decoder.decode(block.buffer);
this.#logger.debug(text);
this[ENV].free(addr);
},

log_error: (addr: bigint) => {
Expand All @@ -419,6 +426,7 @@ export class CallContext {
}
const text = this.#decoder.decode(block.buffer);
this.#logger.error(text);
this[ENV].free(addr);
},
};

Expand Down
Loading