Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: host takes ownership of memory blocks it gets as arguments #90

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Sep 19, 2024

Updates var, config and http_request to free memory handles passed in as arguments

Similar to extism/extism#743 and extism/go-sdk#70

src/call-context.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@chrisdickinson chrisdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zshipko zshipko merged commit 8bf9c28 into main Sep 23, 2024
5 checks passed
@zshipko zshipko deleted the host-memory branch September 23, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants