Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this upgrade, I also upgrade golangci-lint to close #406. In order to successfully install a newer golangci-lint locally, I had to rip out the
hack/tools
workflow and run the linter in a container instead. Per the golangci-lint docs, installing binaries or using a container is preferred for local installation, andgo install
(which is what thehack/tools
workflow used) is not guaranteed to work: https://golangci-lint.run/welcome/install/#install-from-source