chore: run CI with Go version from mod file #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
force-pushed
the
go-version-from-mod
branch
from
80a8712
to
34b23ee
Compare
displague
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the go.mod to drive Go version choice in CI makes it easier to upgrade to newer versions of Go. Since this CLI is shipped as a binary and not meant to be used as a module, there's not much reason to do matrix testing on multiple versions of Go.
This was broken out of #461 because the E2E test workflow uses a
pull_request_targettrigger. That trigger means that the workflow always uses the workflow configuration from themainbranch, so it's impossible for the E2E workflow to pass on that PR because--if we don't merge this PR first--the workflow configuration has to be updated in order to run on a different version of Go.