Replace wrong single and double quotations with correct one #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insight
Changelog
|
Insight
Changelog
|
|
The http://www.thejavageek.com/2015/04/10/dont-repeat-yourself-principle/ is broken as thejavageek.com domain is for sale so I will be replacing that link with something else |
Insight
Changelog
|
Insight
|
Insight
|
Merged
nem035
previously approved these changes
Jan 11, 2022
Insight
|
Insight
|
I could not find a valuable link and the current one is deemed "unsafe", so I will remove it
Insight
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our "Solve this question" would break for
type-in-the-gapwith “, ”, and ’.After testing, switching them to " and ' solves the issue.
It is hard to check only questions for all 273 files containing these "wrong quotations". So I did a content-wide search and replaced them in both content and questions/question answers.
I can't upload the video here as it is "too large". Msg me and I will send you the thread with the reasons and explanations with proof of why I made these changes.