Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python Content #2979

Conversation

Stefan-Stojanovic
Copy link
Collaborator

@Stefan-Stojanovic Stefan-Stojanovic commented Jan 4, 2022

EDIT: All changes are moved to PR per Folder in both Python courses

Move single-line commands from multiple lines back to a single line as we now wrap code blocks

Also fix incorrect indentation in some insights. Example:

# one insight would have this indentation
class Bird(Animal):
    def identify(self):
         # added line, calls parent method
        super().identify()
        print("I am a bird")

Where the comment is slightly more indented and the method and its code are indented with 4 spaces, then in the following insight (in some case the very same insight) the indentation would look like this:

class Bird(Animal):
  def identify(self):
    # added line, calls parent method
    super().identify()
    print("I am a bird")

which is only 2 spaces.

I am going to go for the 2 spaces one as that would make less wrapping between code blocks

Move single-line commands from multiple lines back to a single line as we now wrap code blocks
@enki-hq
Copy link
Collaborator

enki-hq commented Jan 4, 2022

Changelog

File Name Error Message
Pull Request Couldn't find a CHANGELOG entry for this pull request.

If you notice anything wrong with these rules contact andrei@enki.com.

@Stefan-Stojanovic Stefan-Stojanovic changed the title Update the-from-import-statement.md Update Python Content Jan 4, 2022
@Stefan-Stojanovic Stefan-Stojanovic changed the title Update Python Content Update Python Content Currently {WIP} Jan 4, 2022
@enki-hq
Copy link
Collaborator

enki-hq commented Jan 4, 2022

Insight

Insight Name Error Message
distinguish-the-mutability-of-common-types
  • PYTHON OBJECTS: MUTABLE VS. IMMUTABLE pointing to https://codehabitude.com/2013/12/24/python-objects-mutable-vs-immutable/ is broken because HTTP_404

Changelog

File Name Error Message
Pull Request Couldn't find a CHANGELOG entry for this pull request.

If you notice anything wrong with these rules contact andrei@enki.com.

@enki-hq
Copy link
Collaborator

enki-hq commented Jan 4, 2022

Insight

Insight Name Error Message
distinguish-the-mutability-of-common-types
  • PYTHON OBJECTS: MUTABLE VS. IMMUTABLE pointing to https://codehabitude.com/2013/12/24/python-objects-mutable-vs-immutable/ is broken because HTTP_404

Changelog

File Name Error Message
Pull Request Couldn't find a CHANGELOG entry for this pull request.

If you notice anything wrong with these rules contact andrei@enki.com.

nem035
nem035 previously approved these changes Jan 4, 2022
Copy link
Member

@nem035 nem035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@Stefan-Stojanovic Stefan-Stojanovic changed the title Update Python Content Currently {WIP} Update Python Content Currently Jan 5, 2022
…s-that-span-multiple-lines-back-to-a-single-line-in-Python
@enki-hq
Copy link
Collaborator

enki-hq commented Jan 5, 2022

Insight

Insight Name Error Message
distinguish-the-mutability-of-common-types
  • PYTHON OBJECTS: MUTABLE VS. IMMUTABLE pointing to https://codehabitude.com/2013/12/24/python-objects-mutable-vs-immutable/ is broken because HTTP_404

Changelog

File Name Error Message
Pull Request Couldn't find a CHANGELOG entry for this pull request.

If you notice anything wrong with these rules contact andrei@enki.com.

1 similar comment
@enki-hq
Copy link
Collaborator

enki-hq commented Jan 5, 2022

Insight

Insight Name Error Message
distinguish-the-mutability-of-common-types
  • PYTHON OBJECTS: MUTABLE VS. IMMUTABLE pointing to https://codehabitude.com/2013/12/24/python-objects-mutable-vs-immutable/ is broken because HTTP_404

Changelog

File Name Error Message
Pull Request Couldn't find a CHANGELOG entry for this pull request.

If you notice anything wrong with these rules contact andrei@enki.com.

@Stefan-Stojanovic Stefan-Stojanovic changed the title Update Python Content Currently Update Python Content Jan 5, 2022
@enki-hq
Copy link
Collaborator

enki-hq commented Jan 5, 2022

Changelog

File Name Error Message
Pull Request Couldn't find a CHANGELOG entry for this pull request.

If you notice anything wrong with these rules contact andrei@enki.com.

…s-that-span-multiple-lines-back-to-a-single-line-in-Python
@enki-hq
Copy link
Collaborator

enki-hq commented Jan 5, 2022

Changelog

File Name Error Message
Pull Request Couldn't find a CHANGELOG entry for this pull request.

If you notice anything wrong with these rules contact andrei@enki.com.

@enki-hq
Copy link
Collaborator

enki-hq commented Jan 5, 2022

Insight previews:

@@ -65,8 +63,7 @@ print(s.find_longest_match(0, 5, 0, 9))
Complete the `SequenceMatcher` constructor such that empty spaces are treated as junk:

```python
s = SequenceMatcher(??? x: x == ???,
“ abcd”, “abcd abcd”)
s = SequenceMatcher(??? x: x == ???, “ abcd”, “abcd abcd”)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes here look different?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR that changes the quotes is this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants