This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
Refactor imagery loading EventEmitter into store value #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rename this PR (namely, remove "[WIP] " suffix!) when we should review in more detail, or ping here for review ahead of that :) |
louisgv
changed the title
|
@lamby Oops, forgot to remove that. Please review! |
|
LGTM :) |
|
@lamby should I rebase/repush in order to make it pass Travis? |
|
If you haven't already, then yes, please rebase. |
louisgv
force-pushed
the
GH302-refactor-event-emitter
branch
from
3a5af43
to
0663ae3
Compare
|
@reubano Done |
|
When trying to run this on my own, I keep getting a blank screen at port
Anyone else? FYI, it's not specific to this PR either. I see even at 666fb1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I refactored the event emitter inside the TreeView to send it to the global store. This way if any other component need access to the imagery, it can simply grab it from the store.
I also fixed an UX problem with the imagery list expanding button as well as the startcase button, making them more visible and not in the way with the image. (Screenshot below)
Reference to official issue
#302
#295
Screenshot
How Has This Been Tested?
Manual testing
CLA