This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
Improve various code styles #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them later undeneath you.
…path` from os.path. This is more Pythonic.
lamby
force-pushed
the
lamby/wip/code-style
branch
2 times, most recently
from
67b8406
to
5ee05d3
Compare
…fter creating one.
…that this is "computer" text versus "human" text.
…d of testing the directory exists first.
lamby
force-pushed
the
lamby/wip/code-style
branch
from
5ee05d3
to
a4716b1
Compare
lamby
force-pushed
the
lamby/wip/code-style
branch
from
a4716b1
to
0477a6a
Compare
|
Possibly related to #305 (comment) |
|
As in, I can't quite understand the error message! |
|
@isms I'm not blocked, more that I wouldn't want to be introducing any new issue. Indeed, this PR can be merged (renaming to match) |
WGierke
reviewed
Feb 28, 2018
| @@ -1,4 +1,4 @@ | |||
| from collections import OrderedDict | |||
| import collections | |||
There was a problem hiding this comment.
Why do you prefer to import the whole module here while you changed in 5302cfe to directly import methods from a module?
There was a problem hiding this comment.
So in general I prefer to import the modules that Python ships with ("batteries included") as top-level modules. However, I am not 100% dogmatic on this (!) and make some exceptions if that's going to make the code unspeakably ugly. For example,, imagine trying to parse:
os.path.join(os.path.join(os.path.join(os.path.ditpath(os.path.join(os.path.join(os.path.join(....)))
Make sense? :)
|
Any luck all? Would love to get this merged! :) |
isms
approved these changes
Mar 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a large number of code refactoring within the backend (Django) part of the application.