Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for OnAppearing of Page called again, although this page was on already replaced NavigationStack #25596

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix for OnAppearing of Page called again, although this page was on already replaced NavigationStack #25596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/Controls/src/Core/Shell/ShellSection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,10 +1032,22 @@ internal override void SendDisappearing()
PresentedPageDisappearing();
}

bool IsPageVisible()
{
if (this is IShellSectionController sectionController && sectionController.PresentedPage is not null)
{
return sectionController.PresentedPage == ((IShellContentController)CurrentItem)?.Page;
}
return false;
}

internal override void SendAppearing()
{
base.SendAppearing();
PresentedPageAppearing();
if (IsPageVisible())
{
PresentedPageAppearing();
}
}

class NavigationImpl : NavigationProxy
Expand Down
Loading