Fix for OnAppearing of Page called again, although this page was on already replaced NavigationStack #25596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing` only if the page is visible.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
The issue occurs because the ShellSection.SendAppearing() method triggers PresentedPageAppearing() even when PresentedPage doesn’t match CurrentItem. This mismatch causes the OnAppearing() logic of the previous page to execute at the wrong time, resulting in unintended behavior.
Description of Issue Fix
The fix involves adding the IsPageVisible method to contain the logic for determining if the presented page is the current item. The SendAppearing method was updated to ensure that PresentedPageAppearing is called only if the page is visible, correcting the invocation logic and preventing unintended behavior.
Tested the behavior in the following platforms.
Issues Fixed
Fixes #25089
Output
BeforeFix-OnAppearing.mp4
AfterFix-OnAppearing.mp4