Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IDX): no diff with build-all-config-check #2271

Merged
merged 4 commits into from
Oct 28, 2024
Merged

fix(IDX): no diff with build-all-config-check #2271

merged 4 commits into from
Oct 28, 2024
+6 −0

Conversation

marko-k0
Copy link
Member

@marko-k0 marko-k0 commented Oct 28, 2024 •
edited
Loading

Disabling bazel diff logic. #2266 introduced a bug and allowed the logic to work in this CI job.

@github-actions github-actions bot added the fix label Oct 28, 2024
@marko-k0 marko-k0 marked this pull request as ready for review October 28, 2024 08:14
@marko-k0 marko-k0 requested a review from a team as a code owner October 28, 2024 08:14
@github-actions github-actions bot added the @idx label Oct 28, 2024
@marko-k0 marko-k0 added this pull request to the merge queue Oct 28, 2024
Merged via the queue into master with commit 23e9cf8 Oct 28, 2024
30 checks passed
@marko-k0 marko-k0 deleted the marko-build-all-config-check-diff branch October 28, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgundy cgundy cgundy approved these changes

Assignees
No one assigned
Labels
fix @idx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marko-k0 @cgundy