Skip to content

Commit

Permalink
fix(IDX): no diff with build-all-config-check (#2271)
Browse files Browse the repository at this point in the history
Disabling bazel diff logic. #2266
introduced a bug and allowed the logic to work in this CI job.

---------

Co-authored-by: IDX GitHub Automation <IDX GitHub Automation>
  • Loading branch information
marko-k0 authored Oct 28, 2024
1 parent 36cbd80 commit 23e9cf8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows-source/ci-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,9 @@ jobs:
id: bazel-build-config-check
uses: ./.github/actions/bazel-test-all/
with:
# Diff logic is problematic for this CI job
# https://github.com/dfinity/ic/actions/runs/11528673458/job/32096105251
RUN_ON_DIFF_ONLY: false
BAZEL_COMMAND: "build"
BAZEL_TARGETS: "//rs/..."
BAZEL_CI_CONFIG: "--config=check --config=ci --keep_going"
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,9 @@ jobs:
id: bazel-build-config-check
uses: ./.github/actions/bazel-test-all/
with:
# Diff logic is problematic for this CI job
# https://github.com/dfinity/ic/actions/runs/11528673458/job/32096105251
RUN_ON_DIFF_ONLY: false
BAZEL_COMMAND: "build"
BAZEL_TARGETS: "//rs/..."
BAZEL_CI_CONFIG: "--config=check --config=ci --keep_going"
Expand Down

0 comments on commit 23e9cf8

Please sign in to comment.