Bugfix/nested elements disallow actions in revisions

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Fixed a deprecation error. ([#15873](https://github.com/craftcms/cms/issues/15873))
 - Fixed a bug where element sources weren’t keyboard-selectable. ([#15876](https://github.com/craftcms/cms/issues/15876))
 - Fixed a bug where Craft wasn’t auto-detecting interactive terminals on Windows.
+- Fixed a bug where element actions were allowed on nested entries when viewing a revision. ([#15879](https://github.com/craftcms/cms/pull/15879))
 
 ## 5.4.7.1 - 2024-10-09
 

src/controllers/ElementIndexesController.php

@@ -838,7 +838,7 @@ protected function elementResponseData(bool $includeContainer, bool $includeActi
 
  // Get the action head/foot HTML before any more is added to it from the element HTML
  if ($includeActions) {
- $responseData['actions'] = $this->actionData();
+ $responseData['actions'] = $this->viewState['static'] === true ? [] : $this->actionData();
  $responseData['actionsHeadHtml'] = $view->getHeadHtml();
  $responseData['actionsBodyHtml'] = $view->getBodyHtml();
  $responseData['exporters'] = $this->exporterData();

src/elements/NestedElementManager.php

@@ -468,6 +468,7 @@ public function getIndexHtml(?ElementInterface $owner, array $config = []): stri
  'prevalidate' => false,
  'pageSize' => 50,
  'storageKey' => null,
+ 'static' => $owner->getIsRevision(),
  ];
 
  if ($config['storageKey'] === null) {
@@ -514,6 +515,7 @@ function(string $id, array $config, string $attribute, array &$settings) use ($o
  'actions' => [],
  'canHaveDrafts' => $elementType::hasDrafts(),
  'storageKey' => $config['storageKey'],
+ 'static' => $config['static'],
  ];
 
  if ($config['sortable']) {

src/helpers/Cp.php

@@ -579,6 +579,11 @@ public static function elementCardHtml(ElementInterface $element, array $config
  'sortable' => false,
  ];
 
+ if ($element->getIsRevision()) {
+ $config['showActionMenu'] = false;
+ $config['selectable'] = false;
+ }
+
  $color = $element instanceof Colorable ? $element->getColor() : null;
 
  $classes = ['card'];

src/web/assets/cp/src/js/BaseElementIndex.js

@@ -1567,6 +1567,7 @@ Craft.BaseElementIndex = Garnish.Base.extend(
  params.viewState.showHeaderColumn = this.settings.showHeaderColumn;
  params.viewState.inlineEditing = this.inlineEditing;
  params.viewState.nestedInputNamespace = this.nestedInputNamespace;
+ params.viewState.static = this.settings.static;
 
  // override viewState.mode in case it's different from what's stored
  params.viewState.mode = this.viewMode;
@@ -3762,6 +3763,7 @@ Craft.BaseElementIndex = Garnish.Base.extend(
  referenceElementSiteId: null,
  allowedViewModes: null,
  showHeaderColumn: true,
+ static: false,
  criteria: null,
  batchSize: 100,
  disabledElementIds: [],

src/web/assets/cp/src/js/NestedElementManager.js

@@ -419,25 +419,27 @@ Craft.NestedElementManager = Garnish.Base.extend(
  }
 
  const $actionMenuBtn = $element.find('.action-btn');
- const disclosureMenu = $actionMenuBtn
- .disclosureMenu()
- .data('disclosureMenu');
-
- if (Garnish.hasAttr($element, 'data-deletable')) {
- const ul = disclosureMenu.addGroup();
- disclosureMenu.addItem(
- {
- icon: 'trash',
- label: this.settings.deleteLabel || Craft.t('app', 'Delete'),
- destructive: true,
- onActivate: () => {
- if (confirm(this.settings.deleteConfirmationMessage)) {
- this.deleteElement($element);
- }
+ if ($actionMenuBtn.length > 0) {
+ const disclosureMenu = $actionMenuBtn
+ .disclosureMenu()
+ .data('disclosureMenu');
+
+ if (Garnish.hasAttr($element, 'data-deletable')) {
+ const ul = disclosureMenu.addGroup();
+ disclosureMenu.addItem(
+ {
+ icon: 'trash',
+ label: this.settings.deleteLabel || Craft.t('app', 'Delete'),
+ destructive: true,
+ onActivate: () => {
+ if (confirm(this.settings.deleteConfirmationMessage)) {
+ this.deleteElement($element);
+ }
+ },
  },
- },
- ul
- );
+  ul
+ );
+ }
  }
  },