Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/nested elements disallow actions in revisions #15879

Merged

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Oct 10, 2024

Description

Replication steps:

  • create a matrix field with cards view mode;

  • add that field to an entry type used by a section that has revisions on

  • create an entry for that section and create at least one entry inside the matrix field

  • modify + save it a few times to create some revisions

  • view a revision

  • notice that the 3 dots menu is visible, you can click on it and even delete the nested matrix entry, even though we’re viewing a revision;

  • now change the view mode of this matrix field to element index and view a revision again

  • notice that when you click on one of the nested matrix entries, the actions in the element index footer show, and it’s possible to change the status, edit or delete the entry

Solution:

When viewing a revision:

  • don’t show the actions menu in the cards;
  • don’t include actions in the element index view mode;

Related issues

n/a

@brandonkelly brandonkelly merged commit 489207f into 5.x Oct 14, 2024
@brandonkelly brandonkelly deleted the bugfix/nested-elements-disallow-actions-in-revisions branch October 14, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants