-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Integration of skeleton-generic #302
Merged
Merged
Changes from 163 commits
Commits
Show all changes
164 commits
Select commit
Hold shift + click to select a range
abcda87
First commit
jsf9k 40aec83
Remove molecule test from Travis CI config
jsf9k 389bc39
Rename repo to skeleton-generic
jsf9k d92b411
Merge pull request #1 from cisagov/improvement/rename
jsf9k d6eb32f
Remove author information from README
jsf9k 2b479fd
Merge pull request #2 from cisagov/improvement/remove_author_from_readme
jsf9k 4d87c35
Update the pyenv installation instructions
jsf9k 3b47b47
Merge pull request #3 from cisagov/improvement/update_pyenv_instructions
jsf9k 13a1807
Add pre-commit hook for docker-compose linting
jsf9k 74e1452
Remove black and pyupgrade from requirements-test
jsf9k b004df2
Merge pull request #4 from cisagov/improvement/add_precommit_hook_for…
jsf9k 953752e
Add bandit pre-commit hook
jsf9k ce3a97a
Merge pull request #5 from cisagov/improvement/add_bandit
jsf9k c9f8b72
Ignore W503 from flake8
jsf9k 916d7d5
Merge pull request #6 from cisagov/improvement/disable_w503
jsf9k 8e0b1d7
Add pydoc warnings to flake8 config
jsf9k e24cfc6
Merge pull request #7 from cisagov/improvement/enable_docstring
jsf9k 6a64a51
Add a configuration file for Bandit, and configure pre-commit to use it.
felddy 1a98e0e
Improve english
felddy 91b5ccd
Merge pull request #8 from cisagov/improvement-bandit-config
felddy 19afa70
Run pre-commit autoupdate
jsf9k 3a24817
Merge branch 'develop' into improvement-bandit-config
jsf9k c94b79d
Merge pull request #9 from cisagov/improvement-bandit-config
jsf9k eb4fbd7
Make .bandit.yml pass yamllint
jsf9k 76999e2
Merge pull request #10 from cisagov/improvement/make_bandit_config_pa…
jsf9k a9ff3a3
Enable TravisCI caching for pip and pre-commit plugins
jsf9k 4e9280e
Update pre-commit plugins to latest versions
jsf9k a0bd704
Merge pull request #11 from cisagov/improvement/use_travisci_caching
jsf9k b58fa62
Add changes from running pre-commit autoupdate
jsf9k dfdc826
Merge pull request #12 from cisagov/improvement/update_precommit
jsf9k 7404576
Remove the terraform-docs hook
jsf9k 6f566f7
Merge pull request #13 from cisagov/bugfix/turn_off_terraform_docs_hook
jsf9k bd4206b
Configure prettier to ignore JSON files
jsf9k 5da4f0a
Merge pull request #14 from cisagov/improvement/tell_prettier_to_igno…
jsf9k c6f2adb
Update two text blocks to use the console tag instead of the bash tag…
mcdonnnj c449be1
Merge pull request #15 from cisagov/update_contributing_text_blocks
mcdonnnj a13597d
Update pre-commit hooks via pre-commit autoupdate
jsf9k 1843ca0
Add config file for markdownlint
jsf9k 3fee0b8
Rename LICENSE.md to LICENSE, make the other changes that requires
jsf9k 0c5daca
Merge pull request #16 from cisagov/improvement/markdownlint_config
jsf9k 2932d35
Add updates from running pre-commit autoupdate
jsf9k 7864f43
Merge pull request #17 from cisagov/improvement/updates_from_precommi…
jsf9k 78a230d
Add updates from running pre-commit autoupdate
dav3r b189690
Merge pull request #18 from cisagov/improvement/updates_from_precommi…
dav3r 05a136b
Replace Travis-CI with GitHub actions.
felddy 02fb008
Fix action shield link
felddy b31ad85
Disable ansible-lint until they fix their setup.py
felddy b11e39a
Remove extra line.
felddy 12b91c4
Merge pull request #20 from cisagov/improvement/actions
felddy 3c78dd9
Re-enabled ansible-lint and ran pre-commit autoupgrade.
mcdonnnj 7dfd8bf
Merge pull request #21 from cisagov/pre-commit_autoupdate_2019-11-02
mcdonnnj 5d5567d
Add GitHub action caching of pre-commit hooks and pip packages.
felddy c26ea01
Merge branch 'develop' into improvement/action_cache
felddy 99c6115
Remove search for previous pre-commit caches.
felddy 10bbfdf
Merge pull request #22 from cisagov/improvement/action_cache
felddy 7c0b30b
Force pre-commit hooks to use python3.
felddy 30a16a3
Autoupdate pre-commit hooks.
felddy 5e26930
Merge pull request #24 from cisagov/improvement/pre_commit_default_py…
felddy e39dc88
Add codeowners file with team OIS maintainers.
felddy 3f93760
Merge pull request #25 from cisagov/improvement/codeowners
felddy b89eecb
Update CODEOWNERS
felddy 18b5d12
Add seed-isort-config and isort to pre-commit hooks.
mcdonnnj 09afdf3
Merge pull request #28 from cisagov/improvements/pre-commit_add_isort
mcdonnnj 2fa4cbe
Make workflow run when a PR is opened, synchronized, or reopened
jsf9k dbd589d
Improve list formatting
jsf9k a8e35d0
Merge pull request #29 from cisagov/improvement/better-handle-prs-fro…
jsf9k 5327516
Backported changes to CONTRIBUTING.md from the development guide.
mcdonnnj 3f6d654
Merge pull request #31 from cisagov/improvements/add_wsl_instructions
mcdonnnj f7a4166
Update Python version used to 3.8
mcdonnnj 8116a89
Merge pull request #32 from cisagov/improvements/update_python_versio…
mcdonnnj b857939
Run pre-commit autoupdate.
mcdonnnj d99fd00
Flip cache order to mirror how it is done downstream.
mcdonnnj 16872bf
Merge pull request #33 from cisagov/improvement/update_pre-commit_hooks
mcdonnnj e96577b
All references to '-r' for pip calls have been replaced with the more…
mcdonnnj a17986b
Merge pull request #34 from cisagov/improvements/use_verbose_pip_swit…
mcdonnnj 067ee08
Autoupdate pre-commit hooks. Add mypy.
felddy 6369cc6
Merge pull request #35 from cisagov/improvement/static_type_checking
felddy bf36608
Add .mypy_cache to .gitignore
jsf9k c7f339f
Merge pull request #36 from cisagov/improvement/add-mypy-cache-to-git…
jsf9k 454864b
Incorporate the Python version into keys for pip and pre-commit caches.
mcdonnnj b58f7a1
Merge pull request #37 from cisagov/add_python_version_to_cache_keys
mcdonnnj 478f168
Change the cache paths from hardcoded values in their appropriate blo…
mcdonnnj 241484a
Merge pull request #38 from cisagov/change_cache_paths_to_env_variables
mcdonnnj d791334
Add a rule for markdownlint to allow multiple headers with the same n…
mcdonnnj f5fd431
Merge pull request #39 from cisagov/add_mdl_rule_for_MD024
mcdonnnj 61790a9
Fixed broken hook id for pre-commit-terraform:
mcdonnnj 757a861
Merge pull request #40 from cisagov/improvements/update_pre-commit
mcdonnnj 0bc1aab
Ran `pre-commit autoupdate` to get the latest version of the
mcdonnnj b01a0ee
Explicitly install pre-commit hooks as its own step so it's clearer w…
mcdonnnj 1f3d440
Rename action to accurately reflect that we are only linting, not bui…
mcdonnnj 647b351
Sort .gitignore entries.
mcdonnnj 89b098a
Merge pull request #41 from cisagov/bugfix/update_pre-commit_for_pre-…
mcdonnnj c8b4bcf
Update CODEOWNERS
hillaryj 175ae71
Merge pull request #42 from cisagov/hillaryj-owner
hillaryj 8c99c52
Allow events from apb to rebuild this repository weekly.
felddy 3301dfa
Merge pull request #43 from cisagov/improvement/apb-events
felddy 7d7a677
Updated pre-commit configuration with 'pre-commit autoupdate'.
mcdonnnj ce6658a
Update isort pre-commit hook source repository.
mcdonnnj daaebc1
Ran pre-commit autoupdate.
mcdonnnj 2399f24
Remove legacy comment from the isort hook declaration.
mcdonnnj fe4d5eb
Disable the terraform_validate hook.
mcdonnnj 4d4db07
Merge branch 'develop' into improvements/pre-commit_autoupdate_2020-05
mcdonnnj f831ef8
Add final statement to descriptionf or why terraform_validate is disa…
mcdonnnj 64edcc2
Merge branch 'improvements/pre-commit_autoupdate_2020-05' of github.c…
mcdonnnj 70f0cbd
Merge pull request #44 from cisagov/improvements/pre-commit_autoupdat…
mcdonnnj 87ea530
Add setuptools and wheel as pip dependencies
jsf9k 7f8d430
Pull in requirements.txt from requirements-test.txt
jsf9k 6668e3b
Merge pull request #45 from cisagov/improvement/add-wheel
jsf9k af06915
Add tool and docs to automate development environment setup.
felddy c50094a
Fix typo.
felddy 3c2781c
Correct syntax on fence.
felddy 23ef29c
Clarify comment with text from `pyenv local --help`
felddy 5d1d134
Change to python3 to standardize how we call python.
felddy 8a105ca
Respect customs.
felddy ae21af1
Improve usage message.
felddy c5e7edf
Add flag to install pre-commit hooks now.
felddy 482a370
Switch to a POSIX compliant command... command.
felddy 466ef0c
Sort command line flag case statement.
felddy 996ae26
Add recommendation to install brew, instead of assuming it is available.
felddy 31980ed
Clean up usage syntax since we now have multiple options.
felddy db362b9
Normalize quotes.
felddy 174d55b
Merge pull request #46 from cisagov/improvement/setup_env
felddy 91279d3
Perform a pre-commit autoupdate for 2020-07
mcdonnnj 907b89a
Add the black profile to the isort configuration
mcdonnnj 3634093
Merge pull request #47 from cisagov/improvement/autoupdate_pre-commit
mcdonnnj d6fe79d
Update actions/cache to v2
mcdonnnj 6ab69f4
Bump actions/setup-python to v2
mcdonnnj 969efdd
Adjust cache key name
mcdonnnj e0fbcda
Merge pull request #48 from cisagov/improvement/switch_setup-python_a…
mcdonnnj 332e5a7
Run pre-commit autoupdate
mcdonnnj 3e9441c
Update CODEOWNERS to resolve #50
mcdonnnj ae4aa12
Update lint job to resolve #49
mcdonnnj d8f14e8
Sort .gitignore while I'm here
mcdonnnj 1541144
Merge pull request #51 from cisagov/pre-commit_updates
mcdonnnj 6a4164d
Bump build workflow python-version to 3.9
felddy c9c00f1
Replace deprecated set-env workflow syntax
felddy 7389a1b
Enable weekly dependabot scans of github-actions and pip
felddy 0923631
Merge pull request #52 from cisagov/improvement/workflows
felddy e14ecde
Add link to how to set up a new repo with skeletons
hillaryj 57d927d
Add line breaks for linting
hillaryj b5ef97d
Remove seed-isort-config pre-commit hook
mcdonnnj de409db
Use local filename in README link
mcdonnnj 59eef4c
Run pre-commit autoupdate
mcdonnnj a9ef644
Merge pull request #53 from cisagov/add-how-to-skeleton
mcdonnnj 1928db6
Merge branch 'develop' into pre-commit_updates
mcdonnnj 4d88e06
Merge pull request #54 from cisagov/pre-commit_updates
mcdonnnj 919460c
Change repo for the prettier pre-commit hook
mcdonnnj e44762c
Merge pull request #55 from cisagov/migrate_prettier_hook
mcdonnnj a842abb
Insist that the cisagov devs are the owners of the .github directory
jsf9k 5b199bc
Remove offending slash
jsf9k 02c5a6f
Use the python version output by actions/setup-python
jsf9k 64c3fb6
Organize pre-commit hooks
mcdonnnj 763d247
Merge pull request #60 from cisagov/organize_pre-commit_requirements
mcdonnnj 1310cfd
Merge branch 'develop' into improvement/insist-that-devs-own-gihub-dir
jsf9k 2a2067f
Merge pull request #57 from cisagov/improvement/insist-that-devs-own-…
jsf9k b638143
Merge branch 'develop' into improvement/get-python-version-more-simply
jsf9k 3b312c4
Merge pull request #59 from cisagov/improvement/get-python-version-mo…
jsf9k f4131e5
Clean up our actions/cache step
mcdonnnj df674df
Merge pull request #62 from cisagov/improvement/clean_up_actions/cache
mcdonnnj 5eceeb3
Merge github.com:cisagov/skeleton-generic into initial_skeletonization
mcdonnnj a9d398d
Comment out pre-commit hooks
mcdonnnj 6fb705b
Fix missed references to skeleton-generic
mcdonnnj 22c028b
Restore pattern to .gitignore
mcdonnnj 3746700
Merge branch 'develop' into initial_skeletonization
mcdonnnj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
--- | ||
# Configuration file for the Bandit python security scanner | ||
# https://bandit.readthedocs.io/en/latest/config.html | ||
|
||
# Tests are first included by `tests`, and then excluded by `skips`. | ||
# If `tests` is empty, all tests are are considered included. | ||
|
||
tests: | ||
# - B101 | ||
# - B102 | ||
|
||
skips: | ||
# - B101 # skip "assert used" check since assertions are required in pytests |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
[flake8] | ||
max-line-length = 80 | ||
# Select (turn on) | ||
# * Complexity violations reported by mccabe (C) - | ||
# http://flake8.pycqa.org/en/latest/user/error-codes.html#error-violation-codes | ||
# * Documentation conventions compliance reported by pydocstyle (D) - | ||
# http://www.pydocstyle.org/en/stable/error_codes.html | ||
# * Default errors and warnings reported by pycodestyle (E and W) - | ||
# https://pycodestyle.readthedocs.io/en/latest/intro.html#error-codes | ||
# * Default errors reported by pyflakes (F) - | ||
# http://flake8.pycqa.org/en/latest/glossary.html#term-pyflakes | ||
# * Default warnings reported by flake8-bugbear (B) - | ||
# https://github.com/PyCQA/flake8-bugbear#list-of-warnings | ||
# * The B950 flake8-bugbear opinionated warning - | ||
# https://github.com/PyCQA/flake8-bugbear#opinionated-warnings | ||
select = C,D,E,F,W,B,B950 | ||
# Ignore flake8's default warning about maximum line length, which has | ||
# a hard stop at the configured value. Instead we use | ||
# flake8-bugbear's B950, which allows up to 10% overage. | ||
# | ||
# Also ignore flake8's warning about line breaks before binary | ||
# operators. It no longer agrees with PEP8. See, for example, here: | ||
# https://github.com/ambv/black/issues/21. Guido agrees here: | ||
# https://github.com/python/peps/commit/c59c4376ad233a62ca4b3a6060c81368bd21e85b. | ||
ignore = E501,W503 |
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,10 @@ | ||
# Each line is a file pattern followed by one or more owners. | ||
|
||
# These owners will be the default owners for everything in | ||
# the repo. Unless a later match takes precedence, | ||
# these owners will be requested for review when someone | ||
# opens a pull request. | ||
* @dav3r @felddy @hillaryj @jsf9k @mcdonnnj @cisagov/team-ois | ||
# These owners will be the default owners for everything in the | ||
# repo. Unless a later match takes precedence, these owners will be | ||
# requested for review when someone opens a pull request. | ||
* @dav3r @felddy @hillaryj @jsf9k @mcdonnnj | ||
|
||
# These folks own any files in the .github directory at the root of | ||
# the repository and any of its subdirectories. | ||
/.github/ @dav3r @felddy @hillaryj @jsf9k @mcdonnnj |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
--- | ||
|
||
version: 2 | ||
updates: | ||
- package-ecosystem: "github-actions" | ||
directory: "/" | ||
schedule: | ||
interval: "weekly" | ||
|
||
- package-ecosystem: "pip" | ||
directory: "/" | ||
schedule: | ||
interval: "weekly" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
version: "1" | ||
|
||
lineage: | ||
skeleton: | ||
remote-url: https://github.com/cisagov/skeleton-generic.git |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
--- | ||
name: build | ||
|
||
on: | ||
push: | ||
pull_request: | ||
repository_dispatch: | ||
types: [apb] | ||
|
||
env: | ||
PIP_CACHE_DIR: ~/.cache/pip | ||
PRE_COMMIT_CACHE_DIR: ~/.cache/pre-commit | ||
|
||
jobs: | ||
lint: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- id: setup-python | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: 3.9 | ||
- uses: actions/cache@v2 | ||
env: | ||
BASE_CACHE_KEY: "${{ github.job }}-${{ runner.os }}-\ | ||
py${{ steps.setup-python.outputs.python-version }}-" | ||
with: | ||
path: | | ||
${{ env.PIP_CACHE_DIR }} | ||
${{ env.PRE_COMMIT_CACHE_DIR }} | ||
key: "${{ env.BASE_CACHE_KEY }}\ | ||
${{ hashFiles('**/requirements-test.txt') }}-\ | ||
${{ hashFiles('**/requirements.txt') }}-\ | ||
${{ hashFiles('**/.pre-commit-config.yaml') }}" | ||
restore-keys: | | ||
${{ env.BASE_CACHE_KEY }} | ||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install --upgrade --requirement requirements-test.txt | ||
- name: Set up pre-commit hook environments | ||
run: pre-commit install-hooks | ||
- name: Run pre-commit on all files | ||
run: pre-commit run --all-files |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
*~ | ||
playbook.retry | ||
__pycache__ | ||
.coverage | ||
.mypy_cache | ||
.pytest_cache | ||
.python-version | ||
.terraform | ||
terraform.tfstate* | ||
*.tfvars | ||
*.dyn.tf | ||
*.tfvars | ||
packer_cache | ||
terraform.tfstate | ||
terraform.tfstate.backup |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
[settings] | ||
combine_star=true | ||
force_sort_within_sections=true | ||
|
||
import_heading_stdlib=Standard Python Libraries | ||
import_heading_thirdparty=Third-Party Libraries | ||
import_heading_firstparty=cisagov Libraries | ||
|
||
# Run isort under the black profile to align with our other Python linting | ||
profile=black |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"MD013": { | ||
"code_blocks": false, | ||
"tables": false | ||
}, | ||
"MD024": { | ||
"allow_different_nesting": true | ||
}, | ||
"default": true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
--- | ||
default_language_version: | ||
# force all unspecified python hooks to run python3 | ||
python: python3 | ||
|
||
repos: | ||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v3.2.0 | ||
hooks: | ||
- id: check-executables-have-shebangs | ||
- id: check-json | ||
- id: check-merge-conflict | ||
- id: check-xml | ||
- id: debug-statements | ||
- id: detect-aws-credentials | ||
args: | ||
- --allow-missing-credentials | ||
- id: detect-private-key | ||
- id: end-of-file-fixer | ||
exclude: files/(issue|motd) | ||
- id: mixed-line-ending | ||
args: | ||
- --fix=lf | ||
- id: pretty-format-json | ||
args: | ||
- --autofix | ||
- id: requirements-txt-fixer | ||
- id: trailing-whitespace | ||
|
||
# Text file hooks | ||
# - repo: https://github.com/igorshubovych/markdownlint-cli | ||
# rev: v0.24.0 | ||
# hooks: | ||
# - id: markdownlint | ||
# args: | ||
# - --config=.mdl_config.json | ||
- repo: https://github.com/prettier/pre-commit | ||
rev: v2.1.2 | ||
hooks: | ||
- id: prettier | ||
# - repo: https://github.com/adrienverge/yamllint | ||
# rev: v1.25.0 | ||
# hooks: | ||
# - id: yamllint | ||
|
||
# Shell script hooks | ||
# - repo: https://github.com/detailyang/pre-commit-shell | ||
# rev: 1.0.5 | ||
# hooks: | ||
# - id: shell-lint | ||
|
||
# Python hooks | ||
# - repo: https://github.com/PyCQA/bandit | ||
# rev: 1.6.2 | ||
# hooks: | ||
# - id: bandit | ||
# args: | ||
# - --config=.bandit.yml | ||
# - repo: https://github.com/python/black | ||
# rev: 20.8b1 | ||
# hooks: | ||
# - id: black | ||
# - repo: https://gitlab.com/pycqa/flake8 | ||
# rev: 3.8.4 | ||
# hooks: | ||
# - id: flake8 | ||
# additional_dependencies: | ||
# - flake8-docstrings | ||
# - repo: https://github.com/timothycrosley/isort | ||
# rev: 5.6.4 | ||
# hooks: | ||
# - id: isort | ||
# - repo: https://github.com/pre-commit/mirrors-mypy | ||
# rev: v0.790 | ||
# hooks: | ||
# - id: mypy | ||
# - repo: https://github.com/asottile/pyupgrade | ||
# rev: v2.7.2 | ||
# hooks: | ||
# - id: pyupgrade | ||
|
||
# Ansible hooks | ||
# - repo: https://github.com/ansible/ansible-lint.git | ||
# rev: v4.3.5 | ||
# hooks: | ||
# - id: ansible-lint | ||
# # files: molecule/default/playbook.yml | ||
|
||
# Terraform hooks | ||
- repo: https://github.com/antonbabenko/pre-commit-terraform.git | ||
rev: v1.43.0 | ||
hooks: | ||
- id: terraform_fmt | ||
# There are ongoing issues with how this command works. This issue | ||
# documents the core issue: | ||
# https://github.com/hashicorp/terraform/issues/21408 | ||
# We have seen issues primarily with proxy providers and Terraform code | ||
# that uses remote state. The PR | ||
# https://github.com/hashicorp/terraform/pull/24887 | ||
# has been approved and is part of the 0.13 release to resolve the issue | ||
# with remote states. | ||
# The PR | ||
# https://github.com/hashicorp/terraform/pull/24896 | ||
# is a proprosed fix to deal with `terraform validate` with proxy | ||
# providers (among other configurations). | ||
# We have decided to disable the terraform_validate hook until the issues | ||
# above have been resolved, which we hope will be with the release of | ||
# Terraform 0.13. | ||
# - id: terraform_validate | ||
|
||
# Docker hooks | ||
# - repo: https://github.com/IamTheFij/docker-pre-commit | ||
# rev: v2.0.0 | ||
# hooks: | ||
# - id: docker-compose-check |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# Already being linted by pretty-format-json | ||
*.json | ||
# Already being linted by mdl | ||
*.md | ||
# Already being linted by yamllint | ||
*.yaml | ||
*.yml |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
extends: default | ||
|
||
rules: | ||
# yamllint doesn't like when we use yes and no for true and false, | ||
# but that's pretty standard in Ansible. | ||
truthy: disable |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need the
*.dyn.tf
line for the code generated in theterraform/dyn_*
directories? I'm not sure, so I'm asking.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's a good question. We probably do and I just got overzealous with
.gitignore
cleaning.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have restored that pattern in 22c028b