Initial Integration of skeleton-generic #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename repo to skeleton-generic
Remove author information from README
In particular, mention pyenv-installer.
Update the pyenv installation instructions
They are not needed there. Also run pre-commit autoupdate to pick up the latest version of hooks.
…_docker_compose Add pre-commit hook for docker-compose linting
Also ran pre-commit autoupdate, which picked up a newer version of the pyupgrade hook.
Add bandit pre-commit hook
This is a warning about line breaks before binary operators. It no longer agrees with PEP8. See, for example, here: psf/black#21. Guido agrees here: python/peps@c59c437.
Ignore W503 from flake8
Also add flake8-docstrings as an additional dependency in the .pre-commit-config.yml file.
Add pydoc warnings to flake8 config
Improvement bandit config
Also update the URL for black since it moved GitHub orgs from ambv to python.
Run pre-commit autoupdate
…ss_yamllint Make .bandit.yml pass yamllint
This should speed up TravisCI builds.
Via pre-commit autoupdate.
Use TravisCI caching to speed up builds
Add changes from running pre-commit autoupdate
There is no need to run python code to determine the python version. Resolves #58. See here for details: https://github.com/actions/setup-python/blob/main/action.yml#L14-L16
Group related pre-commit hooks together. Make sure that hooks are alphabetically sorted within those groups.
Organize and Sort pre-commit Hooks
…gihub-dir Ensure that the cisagov devs are the owners of the .github directory
…re-simply Use the python version output by actions/setup-python
Removed name because it was not more informative than the default. Swapped out a hardcoded job reference for the github.job context value. Switch the base cache key to a step environment value so we can set it once and reuse. Removed additional restore-key value that might have undesirable results.
Improve actions/cache Configuration
Comment out all hooks that haven't been run and resolved yet. This leaves only the hooks used in #295 enabled for now.
mcdonnnj
added
the
improvement
mcdonnnj
requested review from
dav3r,
felddy,
hillaryj,
jsf9k and
a team
as code owners
jsf9k
approved these changes
Dec 17, 2020
| *.tfvars | ||
| *.dyn.tf |
There was a problem hiding this comment.
Do we still need the *.dyn.tf line for the code generated in the terraform/dyn_* directories? I'm not sure, so I'm asking.
There was a problem hiding this comment.
Ah, that's a good question. We probably do and I just got overzealous with .gitignore cleaning.
There was a problem hiding this comment.
I have restored that pattern in 22c028b
I was overzealous and removed the *.dyn.tf pattern from this repository's .gitignore file. Since our Terraform configuration uses modules, this is still a necessary pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR is an initial integration of cisagov/skeleton-generic.
💭 Motivation and Context
I'm moving forward with working on #301 , and this gets the framework for everything in place to work on passing each
pre-commithook group and merging those in their own PRs.🧪 Testing
The GitHub Actions workflow is passing with the pared down
pre-commitconfiguration to align with the progress made in #295 .✅ Checklist