fix: expire all previous epochs #5279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5279 +/- ##
======================================
- Coverage 71% 71% -0%
======================================
Files 494 496 +2
Lines 85777 86262 +485
Branches 85777 86262 +485
======================================
+ Hits 61165 61474 +309
- Misses 21878 22018 +140
- Partials 2734 2770 +36 ☔ View full report in Codecov by Sentry. |
dandanlen
reviewed
Sep 19, 2024
There was a problem hiding this comment.
@j4m1ef0rd I'll make the below changes.
Will wait for @acdibble and @marcellorigotti 's inputs re. api breakage before merging.
| @@ -350,7 +350,7 @@ type RpcSuspensions = Vec<(Offence, Vec<(u32, state_chain_runtime::AccountId)>)> | |||
|
|
|||
| #[derive(Serialize, Deserialize)] | |||
| pub struct RpcAuctionState { | |||
| blocks_per_epoch: u32, | |||
| epoch_duration: u32, | |||
There was a problem hiding this comment.
Unfortunately this is a breaking change 🙈
We could keep the old name around and flag it as deprecated... or maybe just keep the old name with a comment explaining that the name is for historical reasons...
@acdibble how much of a pain is it for you to change this?
There was a problem hiding this comment.
should be fine as long as we are aware ahead of time. thanks for pointing it out
state-chain/pallets/cf-validator/src/migrations/rename_blocks_per_epoch.rs
Outdated
Show resolved
Hide resolved
state-chain/pallets/cf-validator/src/migrations/rename_blocks_per_epoch.rs
Outdated
Show resolved
Hide resolved
4 tasks
dandanlen
force-pushed
the
fix/expire-prev-epochs
branch
from
981c9b0
to
b311f70
Compare
|
What's the status on this one? |
dandanlen
approved these changes
Oct 18, 2024
dandanlen
force-pushed
the
fix/expire-prev-epochs
branch
from
b311f70
to
b345fa9
Compare
dandanlen
force-pushed
the
fix/expire-prev-epochs
branch
from
afa14c9
to
16bc7c7
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Looks like it's hitting a migration issue @j4m1ef0rd |
dandanlen
reviewed
Oct 24, 2024
syan095
added a commit
that referenced
this pull request
Oct 29, 2024
…waps-close-accounts * origin/main: (44 commits) fix: expire all previous epochs (#5279) feat: add/update contract swaps parameters (#5343) chore: add address to solana logging (#5353) fix: ignore dust underflows in order fills rpc (#5352) chore: consistent naming prewitnessed (#5351) feat: engine-runner verifies gpg signature of old dylib when downloaded (#5339) feat: tainted transaction reporting (#5310) bug: change_utxo not always present (#5340) feat: structured error return types for rpcs (#5346) chore: unify dependencies to root cargo.toml (#5333) feat: Submit a slot number alongside nonce (#5297) chore: use node version from `.nvmrc` 📌 (#5336) chore: add engine account_info logging (#5347) chore: replace manual scale encoding for ts-scale (#5335) chore: more consistent params in Broker API (#5342) feat: broker can encode btc smart contract call (#5329) chore: localnet recreate script can use defaults (#5338) feat: witnessing btc smart contract swaps (#5331) feat: Solana CCM fallback (#5316) fix: scale types for pending ceremonies (#5286) ... # Conflicts: # Cargo.lock # state-chain/chains/src/sol/api.rs # state-chain/pallets/cf-broadcast/src/migrations.rs # state-chain/pallets/cf-environment/Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1613
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
expire_epochfunction to recursively expire all previous epochs that had not expired yet in chronological order. This should avoid the bug stated in the issue.BlocksPerEpoch->EpochDurationNon-Breaking changes
I think this is non breaking, i'll let you tag it @dandanlen