-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add solana monitoring data #5277
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5277 +/- ##
======================================
- Coverage 70% 70% -0%
======================================
Files 487 487
Lines 87463 87358 -105
Branches 87463 87358 -105
======================================
- Hits 61511 61313 -198
- Misses 22672 22730 +58
- Partials 3280 3315 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, i'd just like to understand better how this will be used. Let's chat tomorrow.
These changes are also breaking, bringing the same problems as #5279 does, correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To summarize:
- New node with old runtime will be broken.
- Old node with new runtime will be ok.
So we can update the monitoring rpc node after the runtime upgrade and we should be ok. However @marcellorigotti is looking into how best to manage this so that we can update the node ahead of time.
f58a07e
to
249d530
Compare
…-sdk-1.15.2 * origin/main: (31 commits) feat: liveness electoral system (#5278) chore: bump asset-balances to match release (#5305) refactor: Strongly-typed identifiers for SwapId/SwapRequestId (#5294) fix: only install solana if `run-job` is true 🐛 (#5304) Chore/debug 3 nodes (#5302) feat: remove swap and retry batch on price impact (#5285) refactor: Collect settings extrinsic in threshold signer pallet into a single extrinsic (#5299) feat: add solana monitoring data (#5277) fix: Redemption amount printed not consistent in rounding (#5296) refactor: use chainflip api for DCA test (#5289) fix: add audit exception for RUSTSEC-2024-0375 (#5303) fix: filter out stale bitcoin utxos (#5291) PRO-1594: Add healthcheck endpoints to broker and lp apis (#5282) Tests elections pallet (#5190) PRO-1620: Ensure that default port is used if none is given in configuration (#5281) test: egress success tests (#5288) feat: localnet scripts to create and recreate easier (#5284) Denote broadcast timeout in target chain blocks. (#5270) fix: force version bump endpoint (#5280) refactor: user friendly bouncer new swap cmd (#5273) ... # Conflicts: # .zepter.yaml # Cargo.lock # api/bin/chainflip-cli/Cargo.toml # api/bin/chainflip-lp-api/src/main.rs # engine/Cargo.toml # state-chain/custom-rpc/Cargo.toml # state-chain/custom-rpc/src/lib.rs # state-chain/pallets/cf-swapping/src/lib.rs # state-chain/runtime/src/monitoring_apis.rs # utilities/Cargo.toml
Pull Request
Closes: PRO-1658
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Add solana monitoring data to monitoring rpc: