feat: Adjustments to defaults, postgres docker example, minor fixes #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are similar when keeping everything, and when choosing to modify and selecting all the default prompts (mainly changing gateway default)
Previously, the the app would fail to install due to file path issues, now it works.
Only for local testing if you don't want to install postgres binaries.
dav1do
changed the title
- Installing globally doesn't work with how the daemon start is currently implemented. Rather than fix that, prefer a local install. We don't need a global install. The test app brings its own node_modules folders and scripts to run ceramic/composedb, and this makes it easier to compare multiple versions.
dbcfd
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While experimenting, I noticed a few minor things and made some adjustments.
-There was a bug installing a test app when the branch had a slash in the name, this has been fixed.
inmemorynetwork and it seemed to work okay.npm install -g. Installing globally doesn't work with how the daemon start is currently implemented. Rather than fix that, prefer a local install as we don't need a global install. The test app brings its own node_modules folders and scripts to run ceramic/composedb, and this makes it easier to compare multiple versions in different folders.I made some changes to the test app which is how I noticed the branch issue.