Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont use npm global installs for ceramic #22

Closed
wants to merge 1 commit into from
Closed

Conversation

3benbox
Copy link

@3benbox 3benbox commented Oct 11, 2023

Startup fails when running wheel quiet generate due to an incorrect path to the ceramic install.

This PR keep all modules local and works fine for me.

If we want to globally install the packages, I think there should be an explicit flag as we're making changes to the system outside the working directory.

@dbcfd
Copy link
Contributor

dbcfd commented Oct 11, 2023

@3benbox sadly, this doesn't work with the example app. The example app expects ceramic to be installed globally. I'd prefer us not installing globally as well.

@3benbox
Copy link
Author

3benbox commented Oct 11, 2023

I think this is working for me with the example app.

Just running "wheel" and keeping the default config completes successfully and I'm able to access the app on http://localhost:3000 with these changes.

Is there some other issue?

@dav1do
Copy link
Contributor

dav1do commented Dec 20, 2023

Ah, I didn't notice this PR.. but I also did the same thing in #26 as the new version of the example app brings its own versions of node_modules now and runs them via scripts.

@3benbox
Copy link
Author

3benbox commented Dec 20, 2023

Ah, I didn't notice this PR.. but I also did the same thing in #26 as the new version of the example app brings its own versions of node_modules now and runs them via scripts.

Ah, thanks! I'll close this

@3benbox 3benbox closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants