Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed deprecated shouldSort properties panel attributes #1202

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Jun 6, 2024

Closes #1200

See bpmn-io/properties-panel@bb1cfb0 if you want to look into why this was done. But basically, list autoSorting was deemed an antifeature. It is completely gone from the properties panel and only throws a log warning. This PR clears those warnings.

Copy link
Contributor

@vsgoulart vsgoulart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Skaiir The changes are ok, but there's a failing test

@Skaiir
Copy link
Contributor Author

Skaiir commented Jun 7, 2024

@vsgoulart Could you try npm run alling the branch locally, would be quite a bit of help because I can't replicate, but the errors are happening every time.

@Skaiir Skaiir merged commit d249701 into main Jun 7, 2024
11 of 12 checks passed
@Skaiir Skaiir deleted the 1200-deprecated-shouldsort branch June 7, 2024 09:46
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants