Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear out usages of shouldSort #1200

Closed
Skaiir opened this issue Jun 6, 2024 · 1 comment
Closed

Clear out usages of shouldSort #1200

Skaiir opened this issue Jun 6, 2024 · 1 comment
Assignees
@Skaiir
Labels
technical debt

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Jun 6, 2024

What should we do?

The shouldSort property of the properties panel has been deprecated, let's clean it out.

Why should we do it?

To stay up to date with the standards of the bpmn.io project, and clear some console warnings ;)
@Skaiir Skaiir added the ready Ready to be worked on label Jun 6, 2024
@Skaiir Skaiir self-assigned this Jun 6, 2024
@Skaiir Skaiir added enhancement New feature or request technical debt and removed enhancement New feature or request labels Jun 6, 2024
Skaiir added a commit that referenced this issue Jun 6, 2024
@Skaiir
chore: removed deprecated shouldSort properties panel attributes
a6a79db 
Closes #1200
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jun 6, 2024
@Skaiir Skaiir mentioned this issue Jun 6, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 6, 2024
Skaiir added a commit that referenced this issue Jun 7, 2024
@Skaiir
chore: removed deprecated shouldSort properties panel attributes
ecc042d 
Closes #1200
@Skaiir
Copy link
Contributor Author

Skaiir commented Jun 7, 2024

Closed via #1202

@Skaiir Skaiir closed this as completed Jun 7, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 7, 2024
Skaiir added a commit that referenced this issue Jun 10, 2024
@Skaiir
chore: removed deprecated shouldSort properties panel attributes
0067b85 
Closes #1200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skaiir Skaiir

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Skaiir