-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement enif_select
and add select
and mkfifo
to file functions
#617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w22/add-enif_select
branch
2 times, most recently
from
June 6, 2023 19:39
1f79b5a
to
e7350d0
Compare
Closed
pguyot
force-pushed
the
w22/add-enif_select
branch
from
June 11, 2023 16:57
e7350d0
to
139ba21
Compare
pguyot
force-pushed
the
w22/add-enif_select
branch
2 times, most recently
from
July 3, 2023 06:32
cf9867d
to
d75c2f3
Compare
pguyot
force-pushed
the
w22/add-enif_select
branch
2 times, most recently
from
July 3, 2023 18:34
e285a0b
to
afb7f8d
Compare
fadushin
reviewed
Jul 5, 2023
fadushin
reviewed
Jul 5, 2023
fadushin
reviewed
Jul 5, 2023
fadushin
approved these changes
Jul 9, 2023
pguyot
force-pushed
the
w22/add-enif_select
branch
4 times, most recently
from
July 16, 2023 22:38
420a931
to
dcf3301
Compare
`enif_select` is an API that allows nifs to use `select(2)` or equivalent, paving the way for nif-based drivers. `enif_select` depends on platform implementations and this PR only implements it on generic_unix platform, using `sys_poll_event` select-like function, namely `kqueue(2)` or `poll(2)`. As a result, `enif_select` does not exactly behaves like `select(2)` and this is documented. For testing, add `mkfifo` and `select` to POSIX file functions. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w22/add-enif_select
branch
from
July 18, 2023 05:16
dcf3301
to
a03e7e6
Compare
bettio
approved these changes
Jul 21, 2023
bettio
added a commit
that referenced
this pull request
Jul 28, 2023
Add enif_monitor Continuation of PR #617 NIF monitors are required for enif_select-based drivers that do not leak, so they can release resources when the target process dies. These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license). SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enif_select
is an API that allows nifs to useselect(2)
or equivalent,paving the way for nif-based drivers.
enif_select
depends on platform implementations and this PR only implementsit on generic_unix platform, using
sys_poll_event
select-like function,namely
kqueue(2)
orpoll(2)
. As a result,enif_select
does not exactlybehaves like
select(2)
and this is documented.For testing, add
mkfifo
andselect
to POSIX file functions.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later