Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for HTML5 events #693

Closed
wants to merge 3 commits into from

Conversation

pguyot
Copy link
Collaborator

@pguyot pguyot commented Jul 19, 2023

HTML event handlers are resources using enif_monitor to unregister events when the listening process dies to prevent leaks and crashes.

Also align format of HTML and JS files using prettier now that their number is
growing

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Signed-off-by: Paul Guyot <pguyot@kallisys.net>
Also align format of HTML and JS files using prettier now that their number is
growing

Signed-off-by: Paul Guyot <pguyot@kallisys.net>
@pguyot pguyot marked this pull request as draft July 19, 2023 21:58
@pguyot pguyot marked this pull request as ready for review July 29, 2023 05:27
@pguyot pguyot changed the base branch from master to release-0.5 July 29, 2023 05:29
@pguyot pguyot changed the base branch from release-0.5 to master July 29, 2023 05:29
bettio added a commit that referenced this pull request Jul 31, 2023
Initial support for HTML5 events

HTML event handlers are resources using `enif_monitor` to unregister events
when the listening process dies to prevent leaks and crashes.

Also align format of HTML and JS files using prettier now that their number is
growing

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
@bettio
Copy link
Collaborator

bettio commented Jul 31, 2023

It has been rebased and manually merged (see 3ddf3ab). Closing it since GitHub didn't notice that I merged it.

@bettio bettio closed this Jul 31, 2023
@pguyot pguyot deleted the w28/add-html5-event-api branch July 31, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants