Adding support for authentication on RabbitMQ #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 19, 2024 16:58
…compose, env and github workflows
added 2 commits
March 19, 2024 17:30
sajith
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
@italovalcy Thank you Italo!
Black for some reason is unhappy about an unrelated file, probably because we last formatted this repo with the previous major version of black. Let us ignore that here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
Description of the change
This PR follows the same structure proposed on atlanticwave-sdx/sdx-controller#223 . Thus, we leverage some environment variables to define the credentials and host/port.
I've also updated the README, env file, docker-compose and github workflows
Local tests
After the proposed change I was able to successful use the SDX-LC with e rabbitmq with custom username/password