Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for authentication on RabbitMQ #107

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Adding support for authentication on RabbitMQ #107

merged 4 commits into from
Mar 21, 2024

Conversation

italovalcy
Copy link
Contributor

Fixes #101

Description of the change

This PR follows the same structure proposed on atlanticwave-sdx/sdx-controller#223 . Thus, we leverage some environment variables to define the credentials and host/port.

I've also updated the README, env file, docker-compose and github workflows

Local tests

After the proposed change I was able to successful use the SDX-LC with e rabbitmq with custom username/password

Copy link
Member

@sajith sajith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@italovalcy Thank you Italo!

Black for some reason is unhappy about an unrelated file, probably because we last formatted this repo with the previous major version of black. Let us ignore that here.

@sajith sajith merged commit c4c34db into main Mar 21, 2024
8 of 9 checks passed
@sajith sajith deleted the fix/issue_101 branch March 21, 2024 15:31
@sajith sajith restored the fix/issue_101 branch March 21, 2024 20:26
@sajith sajith deleted the fix/issue_101 branch March 28, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding credentials to rabbit mq
2 participants