Change ingress_port and egress_port with uni_a and uni_z respectively #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm so sorry, somehow I closed this PR and deleted the branch by mistake when I merged #107. I'm not quite sure how that happened. :-( I can't seem to reopen this PR or restore this branch. @italovalcy, could you maybe try pushing the branch again, after merging |
|
Restoring #107 branch seems to do the trick: I can reopen the PR now. But the base of the branch is probably wrong? Shouldn't this PR be against main branch? |
italovalcy
commented
Apr 2, 2024
|
@congwang09 @YufengXin Could you help with reviewing this PR? I'm a bit behind things, and I probably missed some discussions from February that is possibly relevant here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102
Head-up: this PR sits on top of PR #107
Description of the change