-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ingress_port and egress_port with uni_a and uni_z respectively #110
Conversation
I'm so sorry, somehow I closed this PR and deleted the branch by mistake when I merged #107. I'm not quite sure how that happened. :-( I can't seem to reopen this PR or restore this branch. @italovalcy, could you maybe try pushing the branch again, after merging |
Restoring #107 branch seems to do the trick: I can reopen the PR now. But the base of the branch is probably wrong? Shouldn't this PR be against main branch? |
@congwang09 @YufengXin Could you help with reviewing this PR? I'm a bit behind things, and I probably missed some discussions from February that is possibly relevant here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Fixes #102
Head-up: this PR sits on top of PR #107
Description of the change