Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VLAN reservation #120

Merged
merged 95 commits into from
Jun 29, 2023
Merged

VLAN reservation #120

merged 95 commits into from
Jun 29, 2023

Commits on Mar 23, 2023

  1. vlan reservation #101

    @YufengXin
    YufengXin committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    abcab85 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Merge remote-tracking branch 'origin/main' into 101.vlan

    @sajith
    sajith committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    273e218 View commit details
    Browse the repository at this point in the history

  2. Reformat

    @sajith
    sajith committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    c6ef81a View commit details
    Browse the repository at this point in the history

  3. Update a docstring

    @sajith
    sajith committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4f806b2 View commit details
    Browse the repository at this point in the history

  4. Add log and error check

    @sajith
    sajith committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    23c430a View commit details
    Browse the repository at this point in the history

  5. Update a docstring

    @sajith
    sajith committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    bd9b054 View commit details
    Browse the repository at this point in the history

  6. Update docstring

    @sajith
    sajith committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    005d6a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Add a placeholder test

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    21ac3e2 View commit details
    Browse the repository at this point in the history

  2. Correct method calls

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    1ec7849 View commit details
    Browse the repository at this point in the history

  3. Add a placeholder reserve_vlan_on_path

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    78fcbaf View commit details
    Browse the repository at this point in the history

  4. Add error check and logging

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    2847ad1 View commit details
    Browse the repository at this point in the history

  5. Format a comment

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    11f7c62 View commit details
    Browse the repository at this point in the history

  6. Add a test

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    7f3af7b View commit details
    Browse the repository at this point in the history

  7. Iterate correctly

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    91a0bd7 View commit details
    Browse the repository at this point in the history

  8. Use the correct method name

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    ffadc8d View commit details
    Browse the repository at this point in the history

  9. Add a topology lock

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    b3b7ff7 View commit details
    Browse the repository at this point in the history

  10. Return None from unimplemented method

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    9261029 View commit details
    Browse the repository at this point in the history

  11. Use the right branching test, perhaps

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    e7a5b9a View commit details
    Browse the repository at this point in the history

  12. Shorten code

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    3a1c7ad View commit details
    Browse the repository at this point in the history

  13. Add type signature

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    2f37a7e View commit details
    Browse the repository at this point in the history

  14. Return the right thing from VLAN reservation method

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    661416a View commit details
    Browse the repository at this point in the history

  15. Add TODO items

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    da406b4 View commit details
    Browse the repository at this point in the history

  16. Let the test fail

    @sajith
    sajith committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    16fb247 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Disable the complex case for now

    @sajith
    sajith committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d1761f4 View commit details
    Browse the repository at this point in the history

  2. Add more assertions and a comment about output format

    @sajith
    sajith committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    01ceb36 View commit details
    Browse the repository at this point in the history

  3. Add some data classes to represent the final breakdown

    @sajith
    sajith committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    2df264c View commit details
    Browse the repository at this point in the history

  4. Add some notes about VLAN reservation

    @sajith
    sajith committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    a62dd9f View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Keep some extra assertions around, just in case

    @sajith
    sajith committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    e8c5d8a View commit details
    Browse the repository at this point in the history

  2. Sketch out, poorly, a reserve vlan method

    @sajith
    sajith committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    143ee7b View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Add docstrings to VLAN-related structures, rename them

    @sajith
    sajith committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    f5669af View commit details
    Browse the repository at this point in the history

  2. Return a fake tagged breakdown

    @sajith
    sajith committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    629890f View commit details
    Browse the repository at this point in the history

  3. Add more assertions

    @sajith
    sajith committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    4fcac46 View commit details
    Browse the repository at this point in the history

  4. Log domain breakdown

    @sajith
    sajith committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    058a5b9 View commit details
    Browse the repository at this point in the history

  5. Collect label ranges from links

    @sajith
    sajith committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    7548c3c View commit details
    Browse the repository at this point in the history

  6. Create VLAN tags table from nodes in the topology

    @sajith
    sajith committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    4dc0ffe View commit details
    Browse the repository at this point in the history

  7. Remove debug print

    @sajith
    sajith committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    ff21ad9 View commit details
    Browse the repository at this point in the history

  8. Remove unused

    @sajith
    sajith committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    470fd9d View commit details
    Browse the repository at this point in the history

  9. Remove unused debug prints

    @sajith
    sajith committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    cdfa39c View commit details
    Browse the repository at this point in the history

  10. Pass domain to reservation method

    @sajith
    sajith committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    25c6946 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Attempt to find a VLAN tag

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    5c49acf View commit details
    Browse the repository at this point in the history

  2. Force success for now

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0fae77f View commit details
    Browse the repository at this point in the history

  3. Use the computed VLAN tags

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    2af27b4 View commit details
    Browse the repository at this point in the history

  4. Form VLAN table from links, not nodes

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c7df6d3 View commit details
    Browse the repository at this point in the history

  5. Skip when label range is None

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    1f3e270 View commit details
    Browse the repository at this point in the history

  6. Use more descriptive variable names

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    978fd8d View commit details
    Browse the repository at this point in the history

  7. Place comment at the appropriate place

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    8614d78 View commit details
    Browse the repository at this point in the history

  8. Comment out unused code

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    3525845 View commit details
    Browse the repository at this point in the history

  9. Remove unused code

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    d2976e5 View commit details
    Browse the repository at this point in the history

  10. Remove log statement

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    30d7535 View commit details
    Browse the repository at this point in the history

  11. Remove unused code

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    79b5bf4 View commit details
    Browse the repository at this point in the history

  12. Return early when port ID is invalid

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    e326ce2 View commit details
    Browse the repository at this point in the history

  13. Return early when an available VLAN tag can't be found

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    8c081b8 View commit details
    Browse the repository at this point in the history

  14. Mark reserved tag as in-use

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    022693b View commit details
    Browse the repository at this point in the history

  15. Disable debug print

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    e089384 View commit details
    Browse the repository at this point in the history

  16. Expand labels from links hopefully correctly

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    645d51e View commit details
    Browse the repository at this point in the history

  17. Leave a note about port ID inconsistency

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ca69583 View commit details
    Browse the repository at this point in the history

  18. Form VLAN-tagged results into desired shape

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0bfc182 View commit details
    Browse the repository at this point in the history

  19. Update test assertions

    @sajith
    sajith committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    3092658 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Run isort

    @sajith
    sajith committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    cfe6b11 View commit details
    Browse the repository at this point in the history

  2. Add a method to print VLAN assignment table

    @sajith
    sajith committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    0feff50 View commit details
    Browse the repository at this point in the history

  3. Add a class to represent set of VLAN-tagged breakdowns

    @sajith
    sajith committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5cc8eb2 View commit details
    Browse the repository at this point in the history

  4. Use appropriate comment syntax

    @sajith
    sajith committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    b0fefb6 View commit details
    Browse the repository at this point in the history

  5. Expand all labels

    @sajith
    sajith committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    74beccc View commit details
    Browse the repository at this point in the history

  6. Add a method to expand label ranges

    @sajith
    sajith committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    cec5821 View commit details
    Browse the repository at this point in the history

  7. Remove unused method for creating VLAN table from nodes

    @sajith
    sajith committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3106772 View commit details
    Browse the repository at this point in the history

  8. Rename "interface_id" to "port_id" 

    Nothing by "interface" is known to a topology.
    @sajith
    sajith committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5ced9d1 View commit details
    Browse the repository at this point in the history

  9. Use shorter names

    @sajith
    sajith committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    7b7405e View commit details
    Browse the repository at this point in the history

  10. Loop over segments when testing

    @sajith
    sajith committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5e57d53 View commit details
    Browse the repository at this point in the history

  11. Use itertools to expand label range

    @sajith
    sajith committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    207f129 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Use a shorter way to expand labels

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    a1a034e View commit details
    Browse the repository at this point in the history

  2. Rename VLAN tags table update method

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    907f2cc View commit details
    Browse the repository at this point in the history

  3. Update TODO item

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    89cc724 View commit details
    Browse the repository at this point in the history

  4. Comment out unused code

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    92a28e6 View commit details
    Browse the repository at this point in the history

  5. Form segment name

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    a4af7c6 View commit details
    Browse the repository at this point in the history

  6. Remove TODO

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    078065b View commit details
    Browse the repository at this point in the history

  7. Rename models for clarity

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    3f5ecbd View commit details
    Browse the repository at this point in the history

  8. Return the right type

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    9c0a364 View commit details
    Browse the repository at this point in the history

  9. Shorten long lines

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    70ac586 View commit details
    Browse the repository at this point in the history

  10. Mark private APIs as such

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    b17e1e8 View commit details
    Browse the repository at this point in the history

  11. Mark private methods as such

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    34e40fa View commit details
    Browse the repository at this point in the history

  12. Return VLAN tagged breakdown

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    87f5970 View commit details
    Browse the repository at this point in the history

  13. Return early when a domain can't be found VLAN table

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    4fc53bc View commit details
    Browse the repository at this point in the history

  14. Update test case, abandon redundant test

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    108237b View commit details
    Browse the repository at this point in the history

  15. Return None when VLAN assignment fails

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    c5ccacc View commit details
    Browse the repository at this point in the history

  16. Update VLAN table on initialization too

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    6945618 View commit details
    Browse the repository at this point in the history

  17. Update assertions

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    dc83d9d View commit details
    Browse the repository at this point in the history

  18. Read test data in fewer lines

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    3b07c61 View commit details
    Browse the repository at this point in the history

  19. Assert better

    @sajith
    sajith committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    928d4b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. Assert failure when method is not implemented

    @sajith
    sajith committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    b3fd025 View commit details
    Browse the repository at this point in the history

  2. Mark reserved VLAN tag as in-use

    @sajith
    sajith committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    a92ae35 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Indicate that lock is private

    @sajith
    sajith committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    b99a374 View commit details
    Browse the repository at this point in the history

  2. Reformat

    @sajith
    sajith committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    1e19555 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Assign issues to TODO items

    @sajith
    sajith committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    ac71257 View commit details
    Browse the repository at this point in the history

  2. Remove stale TODO comments

    @sajith
    sajith committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    eb5f0ba View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Reformat

    @sajith
    sajith committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    dc9842f View commit details
    Browse the repository at this point in the history