Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VLAN reservation #120

Merged
merged 95 commits into from
Jun 29, 2023
Merged

VLAN reservation #120

merged 95 commits into from
Jun 29, 2023

Conversation

sajith
Copy link
Member

@sajith sajith commented Jun 13, 2023

Issue is #101.

With changes in this PR, output of TEManager.generate_connection_breakdown() will be of this shape (still a dict, but represented here as JSON), as mentioned in #101 (comment), with the slight change that interface_id has become port_id:

{
    "urn:ogf:network:sdx:topology:zaoxi.net": {
        "name": "ZAOXI_vlan_10001_10001",
        "dynamic_backup_path": true,
        "uni_a": {
            "tag": {
                "value": 10001,
                "tag_type": 1
            },
            "port_id": "urn:ogf:network:sdx:port:zaoxi:A1:2"
        },
        "uni_z": {
            "tag": {
                "value": 10001,
                "tag_type": 1
            },
            "port_id": "urn:ogf:network:sdx:port:zaoxi:B1:1"
        }
    },
    "urn:ogf:network:sdx:topology:sax.net": {
        "name": "SAX_vlan_10001_10001",
        "dynamic_backup_path": true,
        "uni_a": {
            "tag": {
                "value": 10001,
                "tag_type": 1
            },
            "port_id": "urn:ogf:network:sdx:port:sax:B3:1"
        },
        "uni_z": {
            "tag": {
                "value": 10001,
                "tag_type": 1
            },
            "port_id": "urn:ogf:network:sdx:port:sax:B1:1"
        }
    },
    "urn:ogf:network:sdx:topology:amlight.net": {
        "name": "AMLIGHT_vlan_10001_10001",
        "dynamic_backup_path": true,
        "uni_a": {
            "tag": {
                "value": 10001,
                "tag_type": 1
            },
            "port_id": "urn:sdx:port:amlight:B1:1"
        },
        "uni_z": {
            "tag": {
                "value": 10001,
                "tag_type": 1
            },
            "port_id": "urn:sdx:port:amlight.net:A1:1"
        }
    }
}

Note that VLAN assignment can't be considered "done". This is just the initial part, and I wanted to get some feedback and didn't want to get hung up on getting everything right in the first round. I am planning on following this up with some subsequent changes, described in:

Also note that this does not conform to datamodel 2.0.0 spec, or rely on the changes from atlanticwave-sdx/datamodel#88. Let us get that done in another round.

@sajith sajith linked an issue Jun 14, 2023 that may be closed by this pull request
@sajith sajith self-assigned this Jun 14, 2023
@sajith sajith mentioned this pull request Jun 28, 2023
@sajith sajith marked this pull request as ready for review June 29, 2023 14:41
@sajith sajith merged commit 79ef5c7 into main Jun 29, 2023
@sajith sajith deleted the 101.vlan branch June 29, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Implementing/Refactoring the VLAN assignment on L2 paths.
2 participants