Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for app.Name if is empty, and pick the args[0] if so #20474 #20475

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: check for app.Name if is empty, and pick the args[0] if so #20474 #20475

wants to merge 3 commits into from

Conversation

monegim
Copy link

@monegim monegim commented Oct 21, 2024

The appname is specified in the command create, so when the metadata.name is empty, the name could be used from the command line.

Fixes #20474

@monegim monegim requested a review from a team as a code owner October 21, 2024 10:15
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 21, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@monegim monegim changed the title Fix: check for app.Name if is empty, and pick the args[0] if so #20474 fix: check for app.Name if is empty, and pick the args[0] if so #20474 Oct 21, 2024
Mostafa Negim and others added 3 commits October 21, 2024 22:03
@monegim
Fix: check for app.Name if is empty, and pick the args[0] if so argop…
e4e29d9 
…roj#20474

Signed-off-by: Mostafa Negim <mostafa.negim@snapp.cab>
Signed-off-by: Mostafa Negim <mostafa.negim@gmail.com>
@monegim
add: func GetNamespaceAndAppName to split ns/appname
0bd0f2c 
Signed-off-by: Mostafa Negim <mostafa.negim@gmail.com>
@monegim
fix: handle the namespace/appname args[0]
8ebd966 
Signed-off-by: Mostafa Negim <mostafa.negim@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 55.04%. Comparing base (ec499bb) to head (8ebd966).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cmd/util/common.go 0.00% 13 Missing ⚠️
cmd/util/app.go 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20475      +/-   ##
==========================================
- Coverage   55.07%   55.04%   -0.04%     
==========================================
  Files         322      323       +1     
  Lines       54927    54948      +21     
==========================================
- Hits        30253    30244       -9     
- Misses      22068    22109      +41     
+ Partials     2606     2595      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

APPNAME should be used from the command line when app.name from a url is empty
1 participant
@monegim