Fix: check for app.Name if is empty, and pick the args[0] if so #20474

Signed-off-by: Mostafa Negim <mostafa.negim@snapp.cab>
argoproj · Oct 21, 2024 · c9c2d3a · c9c2d3a
1 parent aff5e61
commit c9c2d3a
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/cmd/util/app.go b/cmd/util/app.go
@@ -605,6 +605,10 @@ func constructAppsFromFileUrl(fileURL, appName string, labels, annotations, args
 		return nil, err
 	}
 	for _, app := range apps {
+		// if app.Name is empty, it should be picked from the command line
+		if len(args) == 1 && app.Name == "" {
+			app.Name = args[0]
+		}
 		if len(args) == 1 && args[0] != app.Name {
 			return nil, fmt.Errorf("app name '%s' does not match app spec metadata.name '%s'", args[0], app.Name)
 		}