Defer Selection Set Template - Basic (W/clean up) #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvincestari
force-pushed
the
defer/selection-set-template-basic-anthony
branch
from
9e7848d
to
6cb8b16
Compare
calvincestari
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
OK, I've rebased this after merging #116 and fixed up the selection set template tests. Should be good for merge now.
BobaFetters
pushed a commit
that referenced
this pull request
Nov 2, 2023
f499efa4 chore: Disable `@defer` support (#122) 70fd68cd Merge branch 'main' into feature/defer d6c49617 Defer Selection Set Template - Basic (W/clean up) (#118) f5dc1758 merge: `feature/defer` update to `main` (#116) 2c5463b0 refactor: [1/x] Refactor root field builder for deferred fragments (#74) 25d44b83 Merge branch 'main' into feature/defer 1d8424d3 Merge branch 'main' into feature/defer a8c31ca3 Merge branch 'main' into feature/defer d1a3c0ab feature: Operation definition template supports the `@defer` directive (#31) 6a01891b Merge branch 'project-breakup' into feature/defer 11cf5828 Merge branch 'project-breakup' into feature/defer 723b8648 refactor: Don't require `label` argument for deferred named fragments (#33) 9041eee0 feature: Require `label` argument on `@defer` directive (#28) 01b81541 Migrating defer branch to new project structure git-subtree-dir: apollo-ios-codegen git-subtree-split: f499efa4ee99c7eb86e5f2e6d0b630756c48f0de
This was referenced Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #113. It's all the same code behaviors and tests are the same. I just took that PR and improved the usage of
TemplateStringin theSelectionSetTemplate.