Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Selection Set Template - Basic #113

Closed

Conversation

calvincestari
Copy link
Member

This PR refactors the selection set template to correctly render basic deferred inline fragments. By 'basic' I mean a simple @defer directive on an inline fragment with and without a type case specification, on the same and on a different type case.

This is not intended to be a complete change set for all deferred fragments. Instead this will allow generation of a complete model for a simple deferred fragment operation so I can move on to the next piece of the stack - the executor. There are warnings in place to mark where more complex test cases are needed.

This will generate the following sections of an operation model for deferred inline fragments:

  • selections
  • field accessor
  • fragment accessor
  • root type entity

The selection set template test diff still looks like a bit of a mess so the tests to focus on are:

@calvincestari
Copy link
Member Author

Closing this in favour of #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant