Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuing cleanup for newer OTP's #22

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Continuing cleanup for newer OTP's #22

wants to merge 9 commits into from

Commits on Sep 25, 2023

  1. remove liveness and readiness probes

    @tsloughter
    tsloughter committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f6922fb View commit details
    Browse the repository at this point in the history

  2. remove unneeded in OTP-23+ SCHEDULERS env variable

    @tsloughter
    tsloughter committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    264c6e6 View commit details
    Browse the repository at this point in the history

  3. add ERL_DIST_PORT to container environment so epmd isn't used

    @tsloughter
    tsloughter committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    9663217 View commit details
    Browse the repository at this point in the history

  4. remove unneedd +S from dev_vm.args

    @tsloughter
    tsloughter committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f0ac7ac View commit details
    Browse the repository at this point in the history

  5. add an 'apt update' to the runner's apt usage

    @tsloughter
    tsloughter committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c581206 View commit details
    Browse the repository at this point in the history

  6. cleanup whitespace in sys config files

    @tsloughter
    tsloughter committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    47ff757 View commit details
    Browse the repository at this point in the history

  7. include uuid in http app

    @tsloughter
    tsloughter committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    00bfb0e View commit details
    Browse the repository at this point in the history

  8. add back readiness probe, used for autoscaling

    @tsloughter
    tsloughter committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    dcd14fc View commit details
    Browse the repository at this point in the history

  9. remove unnused healthcheck and shutting down term 

    healthz is no longer needed because the liveness check is removed.

Toggling to shutting down and returning a 503 from the ready check
isn't useful because the pod will already be being removed from the
routes and readiness checks are infrequent -- mainly used for
autoscaling.
    @tsloughter
    tsloughter committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d96fa77 View commit details
    Browse the repository at this point in the history