Continuing cleanup for newer OTP's #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
========================================
- Coverage 6.24% 6.15% -0.10%
========================================
Files 20 20
Lines 1713 1707 -6
========================================
- Hits 107 105 -2
+ Misses 1606 1602 -4
☔ View full report in Codecov by Sentry. |
healthz is no longer needed because the liveness check is removed. Toggling to shutting down and returning a 503 from the ready check isn't useful because the pod will already be being removed from the routes and readiness checks are infrequent -- mainly used for autoscaling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removal of liveness and readiness probes are a little out of place here, so I can pop those out I suppose.
Main thing is the schedulers +S can be removed and ERL_DIST_PORT used in place of epmd.