Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(topicsSelection): use headless ui component #519

Merged

Conversation

bmartins-42
Copy link
Contributor

  • Define topic interface and default values
  • Integrate last ui interface from figma
  • Rework component with HeadlessUI combobox

Contributor checklist


Description

This task was about reworking the code to use Headless UI and integrate the latest visual from Figma

image
image
image

Related issue

#276

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 31, 2023 13:42
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 31, 2023
Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit ca07157
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6544b169546b0400071ede87
😎 Deploy Preview https://deploy-preview-519--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -847,5 +847,13 @@
"title": "Our Supporters"
}
}
},
"global": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bmartins-42! FYI this will get switched after this gets merged in. I made the decision to flatten the i18n JSON so that we can search for the keys and their usages in a full codebase search. This will go into the top most _common name scheme :) More details for this are in #511.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come to think of it though, _global makes more sense :) Thanks for the suggestion!

@andrewtavis
Copy link
Member

@bmartins-42, checking it out now: on selection the topics aren't staying the cta color 🤔 Is the color just not updating, or is the selection getting canceled. And another question: is the user able to select more than one?

@andrewtavis
Copy link
Member

andrewtavis commented Nov 2, 2023

Thanks so much for the work here! It's looking great! 😊 Seems like we're very close to closing this out :)

@bmartins-42
Copy link
Contributor Author

@bmartins-42, checking it out now: on selection the topics aren't staying the cta color 🤔 Is the color just not updating, or is the selection getting canceled. And another question: is the user able to select more than one?

Strange, I will check this tomorrow.

@bmartins-42
Copy link
Contributor Author

@andrewtavis I fixed the issue, I didn't clean up correctly my work... It should be ok, I also updated the i18n file.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so great, @bmartins-42 😊 Really am so grateful for the help here! :) :) I'll try to finalize the hover coloration in #521 so that it's really looking good for the sync on Saturday 🚀

I'll write some comments on how this is working for accessibility in the issue, as I think that further changes should be in a new one as this 100% solves the original issue!

Thank you!

@andrewtavis andrewtavis merged commit 80250b9 into activist-org:main Nov 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants