-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sweep of en-US.JSON file to make sure repeat strings are minimized #511
Comments
I'll look into this a bit starting now, but ideas and feedback are very welcome! |
Something that we'll likely need to do is create a common key that can be moved up into higher levels of the JSON tree. An idea would be "card-change-account-info": {
"_common": {
"enter-your-password": "Enter your password",
...
},
"email": {
"enter-new-email": "Enter new email",
"enter-old-email": "Enter old email",
...
},
"password": {
"enter-current-password": "Enter current password",
"enter-new-password": "Enter new password",
...
}
} Putting the underscore at the front would put these at the start of the i18n JSON file sub-trees :) |
Ping @ahmedy00, @felipolis and @luuu-xu: could I ask for opinions on the syntax mentioned in the comment above? The purpose here is to try to avoid having repeat keys in each component. We could also have a |
Checked this with @momanyisamuel and we're in agreement that this makes sense 😊 Another thing that's being added into this is if we're using the same string on the same page for two different functions then we can list those functionalities in alphabetical order :) So we'll have |
ec79bc5 is a major change to the i18n |
I also added find_repeat_i18n_values.py that we can use to do periodic checks of the i18n keys and combine them if there are repeats. We can also maybe add this into a workflow at some point 🤔 |
Based on some work in #519, I think we should go with a sub-name of |
Terms
Description
This issue is to go through the en-US.json and combine as many strings as possible in order to make sure that when localization happens we don't have a bunch of repeats that the translators need to translate. The styleguide should also be updated with any new rules thought up to keep repeat values to a minimum :)
The text was updated successfully, but these errors were encountered: