Change ticket messaging when camp is closed. #1404
Conversation
| @@ -5485,10 +5485,14 @@ function form_start() { | |||
| $this->error( __( "It doesn't look like your form submitted any attendee information. Please try again.", 'wordcamporg' ) ); | |||
| } | |||
|
|
|||
| if ( ! $available_tickets ) { | |||
| if ( ! $available_tickets && ! $this->is_wordcamp_closed() ) { | |||
There was a problem hiding this comment.
unsure of the intention here, but guess it might want to be OR instead of AND since we're checking negatives
There was a problem hiding this comment.
I agree it reads a bit weird. It is likely better as ! available_tickets && $this->is_wordcamp_open() but that function doesn't exist. It cannot be an OR clause based on how the code currently functions, however.
There was a problem hiding this comment.
the problem is that this notice would then only show if the wordcamp has closed and there are no available tickets, which is different to the current function which would show this message when there aren't available tickets regardless of status.
There was a problem hiding this comment.
the problem is that this notice would then only show if the wordcamp has closed
The logic is ! $this->is_wordcamp_closed() or specifically ! 'wcpt-closed', meaning anything before closed which I think is fine. I think I'm missing what the problem is. I could create another helper function that targets wcpt-scheduled if that makes this more readable.
There was a problem hiding this comment.
yeah - but if there are available tickets, and the wordcamp is closed, this wouldn't trigger...
| @@ -0,0 +1,74 @@ | |||
| Index: camptix.php | |||
There was a problem hiding this comment.
guess this was included in the PR by mistake?
remove diff file
Related: #1403
When a WordCamp is closed, we still display messaging that appears like a ticket may be sold later. This PR updates that message to explain the camp is closed.
I also created an
is_wordcamp_closedfunction as opposed to checking the post type so we can start to refactor. I updated the only other reference in this file as well.Screenshots
Example: https://asia.wordcamp.org/2024/tickets/