Don't show login banner if no tickets exist. #1403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenDufresne
changed the title
pkevan
reviewed
Oct 21, 2024
| @@ -121,7 +121,7 @@ public function ticket_form_message() { | |||
| } | |||
|
|
|||
| // Warn users that they will need to login to purchase a ticket | |||
| if ( ! is_user_logged_in() ) { | |||
| if ( $camptix->has_tickets_available() && ! is_user_logged_in() ) { | |||
There was a problem hiding this comment.
we should probably check the status of the WordCamp as well, as an event can end with tickets still available.
There was a problem hiding this comment.
oh, I guess it could rely on #1404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently show the "Login" banner regardless of whether the camps are selling tickets. This is particularly problematic for past events.
Looking at WordCamp Asia 2024, you see:
This PR makes it so we only show the banner when tickets are for sale.
Future considerations
In the case where the WordCamp hasn't been completed and new tickets will be going on sale, we could provide a banner to suggest users create an account ahead of time. I don't think that will be a compelling call to action without a useful feature in return like maybe "Create an account to be notified when tickets are back on sale".
I'll also follow up with another PR that changes that ticket-for-sale message.