Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements #1366

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Small improvements #1366

merged 2 commits into from
Feb 5, 2024

Commits on Feb 4, 2024

  1. removed obsolete code for old compilers 

    we require C++-14, so remove work-around for compilers without
partial template specialisation or mutable
    @KrisThielemans
    KrisThielemans committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    2e0df6a View commit details
    Browse the repository at this point in the history

  2. remove redundant checks for projectors 

    "new style" forward/back projector was r6unning checks on _density_ptr, even though
it was created/tested before.

callgrind shows that has_same_charecteristics is actually surprisingly
expensive (as it calls Array::get_index_range(), which is slow).
So now we avoid doing those checks.

This results in a (quite small) speed-up, only relevant for GPU projectors.
    @KrisThielemans
    KrisThielemans committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    8e5ea93 View commit details
    Browse the repository at this point in the history