Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements #1366

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

KrisThielemans
Copy link
Collaborator

remove workarounds from Array and small speed-up for projectors.

These commits are/were on #1236, but that's not yet ready to merge.

we require C++-14, so remove work-around for compilers without
partial template specialisation or mutable
"new style" forward/back projector was r6unning checks on _density_ptr, even though
it was created/tested before.

callgrind shows that has_same_charecteristics is actually surprisingly
expensive (as it calls Array::get_index_range(), which is slow).
So now we avoid doing those checks.

This results in a (quite small) speed-up, only relevant for GPU projectors.
@KrisThielemans KrisThielemans added this to the v6.0 milestone Feb 4, 2024
@KrisThielemans KrisThielemans merged commit 73a16be into UCL:master Feb 5, 2024
7 checks passed
@KrisThielemans KrisThielemans deleted the smallImprovements branch February 5, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant